Compile error in bzr8754[trunk] save_handler.cc on OSX

[Klaus Halfmann]

Just tried to compile trunk on OSX and got:

[ 92%] Building CXX object src/logic/CMakeFiles/logic.dir/save_handler.cc.o
.../trunk/src/logic/player.cc:1483:28: error: no viable overloaded operator[] for type 'const
      std::__1::__vector_base<std::__1::vector<unsigned int, std::__1::allocator<unsigned int> >,
      std::__1::allocator<std::__1::vector<unsigned int, std::__1::allocator<unsigned int> > > >::value_type' (aka 'const
      std::__1::vector<unsigned int, std::__1::allocator<unsigned int> >')
                        oss << stats[ware_index][stats[ware_index].rbegin()];
                               ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/vector:645:47: note: candidate
      function not viable: no known conversion from 'std::__1::vector<unsigned int, std::__1::allocator<unsigned int>
      >::const_reverse_iterator' (aka 'reverse_iterator<__wrap_iter<const unsigned int *> >') to 'std::__1::vector<unsigned int,
      std::__1::allocator<unsigned int> >::size_type' (aka 'unsigned long') for 1st argument
    _LIBCPP_INLINE_VISIBILITY const_reference operator[](size_type __n) const;
                                              ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/vector:644:47: note: candidate
      function not viable: 'this' argument has type 'const std::__1::__vector_base<std::__1::vector<unsigned int,
      std::__1::allocator<unsigned int> >, std::__1::allocator<std::__1::vector<unsigned int, std::__1::allocator<unsigned int> > >
      >::value_type' (aka 'const std::__1::vector<unsigned int, std::__1::allocator<unsigned int> >'), but method is not marked const
    _LIBCPP_INLINE_VISIBILITY reference operator[](size_type __n);

Travis ist still pending https://travis-ci.org/widelands/widelands/builds/405366221 ?

Not sure if this is a broken automatic merge from bug-1678987-save-handler.

[Klaus Halfmann (klaus-halfmann)]

From: https://code.launchpad.net/~widelands-dev/widelands/bug-1678987-save-handler/+merge/349096

Correct: stats[ware_index][stats[ware_index].size() - 1];

Failure: stats[ware_index][stats[ware_index].rbegin()];

Gun: looks like your fix for the codecheck, was the wrong one?

I will have to medidate what the correct syntax might be.

[Klaus Halfmann (klaus-halfmann)]

This now has hit the first branch, too:

bug-1703833-catch-missing-datadir
https://travis-ci.org/widelands/widelands/builds/405393952

Reverting that change fixes ther error, trying to find the correct syntax now.

[Klaus Halfmann (klaus-halfmann)]

trying to fix this now

[Klaus Halfmann (klaus-halfmann)]

Got some fix, will push the branch to lp in a few minutes

[Klaus Halfmann (klaus-halfmann)]

OK the bug is actually in src/logic/player.cc

[Klaus Halfmann (klaus-halfmann)]

OK, Fix is ot actually in trunk yet ....

[GunChleoc (gunchleoc)]

Fixed in build20-rc1