OpenStack Identity (keystone)

Mapping Engine Tester is untested

Bug #1782197 reported by Adam Young
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Vishakha Agarwal
OpenStack Identity (keystone) stein-1

Bug Description

Looking at a coverage report for the Keystone CLI shows that the entirety of

class MappingEngineTester(BaseApp):

Is untested. Since this is production and supported code, this is a risk.

Lance Bragstad (lbragstad)
Changed in keystone:
status: New → Confirmed
importance: Undecided → Medium
tags: added: low-hanging-fruit test-improvement
Revision history for this message
Lance Bragstad (lbragstad) wrote :

This has likely been untested for a while. It would be nice to get this coverage in Rocky, but if it comes down to the wire we can bump this to Stein.

Vishakha Agarwal (vishakha.agarwal)
Changed in keystone:
assignee: nobody → Vishakha Agarwal (vishakha.agarwal)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/603539

Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/603539
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=94e6b284110d1263da6d9c7ff9eb1ea4b1c835eb
Submitter: Zuul
Branch: master

commit 94e6b284110d1263da6d9c7ff9eb1ea4b1c835eb
Author: Vishakha Agarwal <email address hidden>
Date: Wed Sep 19 08:00:51 2018 +0530

    Adding test case for MappingEngineTester

    Mapping Engine Tester is untested. Looking
    at a coverage report for the Keystone CLI
    shows missing test cases for MappingEngine
    Tester. This patch adds the test cases and
    also fixes the compatibility issues of
    MappingEngine with python3.

    Change-Id: Id0844ba1f4e2979d91414d3bc821ab25650c6935
    Closes-Bug: #1782197

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to keystone (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/606912

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to keystone (master)

Reviewed: https://review.openstack.org/606912
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=708dbceef4bcbf982b30fa1d829b41813fdbfcf3
Submitter: Zuul
Branch: master

commit 708dbceef4bcbf982b30fa1d829b41813fdbfcf3
Author: Vishakha Agarwal <email address hidden>
Date: Mon Oct 1 14:39:47 2018 +0530

    Remaining cases of MappingEngineTester

    This patch fixes the remaining unit test cases
    pending for the class MappingeEngineTester.

    Change-Id: I466520017fe41869684b04636107f98f38a75b50
    Related-bug: #1782197

Lance Bragstad (lbragstad)
Changed in keystone:
milestone: none → stein-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 15.0.0.0rc1

This issue was fixed in the openstack/keystone 15.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.