Footprint editor: enter cancels dialog, settings not saved

[John Beard]

In the footprint editor, if you press "Enter", the dialog closes, but the changes are lost. I assume the OK button is wired up incorrectly.

1) Go to footprint editor
2) Tools->General Settings
3) Change, for example, line width
4) Press enter
5) Dialog closes
6) Re-open dialog
7) Value not changed!

----

Application: pcbnew
Version: (5.0.0-rc3-dev-12-geaf938c7e), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.60.0 OpenSSL/1.1.0h zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) nghttp2/1.31.1
Platform: Linux 4.17.2-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.60.0
    Compiler: GCC 8.1.1 with C++ ABI 1012

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

This is fixed in 5.1 (in the unified preferences dialog) but I'm leaving the bug open as we'll likely want to patch the existing dialog in 5.0.1 for it....

[Wayne Stambaugh (stambaughw)]

This should have been fixed by https://git.launchpad.net/kicad/commit/?id=3dcf04fdb8ff50c64a6015546b60beb7b84cc3b4. Please change the status if this is not the case.