Regression: '/' in alias names no longer translated to '_' upon loading libraries in Libedit

[Oivind Toien]

A previous problem, Bug #1766551 that was reported by me and fixed in late March,
"Symbol library editor: Error message on that existing aliases cannot be found on start Edit"
seems to have a regression in the latest Windows nightlies, Version: (5.0.0-rc3-dev-14-g1a2291879), '/' in alias names of old libraries are no longer translated to '_' upon loading libraries when opening the library editor. This was previously fixed, now I get the error message again. Sorry I did not discover this before RC3 was tagged.

Bug #1774774 which is marked as fixed seems to be a related problem but does not mention there is a regression and that it was previously fixed. Nor does the fix appear to have effect on the current problem. The last version I used that I think did not have the regression was kicad-r10571.f785d2749-x86_64.exe installation file June 24, which is shortly before Bug #1774774 was reported fixed. First version I discovered the problem was installation file kicad-r10603.101b68b61-x86_64.exe July 7, but I did not use the library editor in that version before today.

(Bug #1765375 (also reported fixed) appears to be related, but seems to predate Bug #1766551 ).

Application: kicad
Version: (5.0.0-rc3-dev-14-g1a2291879), release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Maciej Suminski (orsonmmz)]

Oivind,

Please post a library that exposes the problem. I have just tested a simple library with slashes in alias names and it worked as expected (at least on Linux, I will check a Windows build later today).

[Oivind Toien (otoien)]

I have attached the old microchip library that has several symbols triggering the problem. A couple of the error message lines I get upon opening libedit, (root of file path under my home directory not included for security):

"...
at line 63 offset 21
01:04:54: Alias 'MCP2050-500-E/SL' not found in library
...\KiCad\KiCad-symbols\Ki-symbols\microchip.dcm'

at line 69 offset 22
01:04:54: Alias 'MCP2515-E/ST' not found in library:

...\KiCad\KiCad-symbols\Ki-symbols\microchip.dcm'
..."

Note that once libedit is open, these symbols has the names correctly translated. Repeated open of libedit will not show the problem unless KiCad is closed. See discussion in Bug #1766551 :" They do appear correctly converted with underscore in the symbol list, edit window and the displayed alias list. " So the problem is really only the error message - perhaps the check occurs before the names in the .dcm files are translated.

(I see this problem because I am overdue to update the libraries again and clean out remains from the old folder structure and some other legacy libraries).

[Maciej Suminski (orsonmmz)]

It is a trivial fix, but most likely will have to wait till 5.0.1 or 5.1.

[Wayne Stambaugh (stambaughw)]

I could have sworn I fixed this. I'm not sure what happened. I'm
tempted to merge this patch and retag v5 rather then wait until 5.0.1.
Are there any objections to doing this?

On 7/16/2018 6:06 AM, Maciej Suminski wrote:
> It is a trivial fix, but most likely will have to wait till 5.0.1 or
> 5.1.
>
> ** Patch added: "0001-eeschema-fix-alias-names-in-.dcm-files.patch"
> https://bugs.launchpad.net/kicad/+bug/1781761/+attachment/5164107/+files/0001-eeschema-fix-alias-names-in-.dcm-files.patch
>
> ** Changed in: kicad
> Milestone: None => 5.0.1
>

[Seth Hillbrand (sethh)]

Wayne-

That was my mistake there. You noted the issue in libfield.cpp and I neglected to check where I made the same error in sch_legacy_plugin.cpp.

I have no objections to re-tagging but it probably makes sense to ping the dev list as I don't think everyone affected monitors the bug reports.

[Wayne Stambaugh (stambaughw)]

@Orson, go ahead and merge this into the dev branch. I doubt there is going to be any issues so you could also merge it into the 5.0 and 5.1 branches as well.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 8ba694e6fdce7479e66b2ccfb4fe64f7981a9689
https://git.launchpad.net/kicad/patch/?id=8ba694e6fdce7479e66b2ccfb4fe64f7981a9689

[Oivind Toien (otoien)]

I can confirm the bug is gone in version
Application: kicad
Version: (6.0.0-rc1-dev-85-g829ba2720), release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON