Torrent addition dialog

[attilaolah]

I just think you should use
    setResizeMode(0, QtGui.QHeaderView.Stretch)
instead of
    setResizeMode(2, QtGui.QHeaderView.Stretch)
or
    setStretchLastSection(1)
so when I resize the dialog box, I don't need to resize the tree view, too. The other columns should be set with resizeColumnToContents(index).

Just my opinion.
aatiis

[attilaolah (attilaolah)]

btw why not make that tree view sortable?

[Christophe Dumez (hydr0g3n)]

Fixed in trunk. Thanks.

You're a pyQt4 programmer I'm guessing ;)

[attilaolah (attilaolah)]

In file src/torrentAddition.h:

Why is the first column not stretched, but the last one?
line 82:
      torrentContentList->header()->resizeSection(0, 200);
      //torrentContentList->header()->setResizeMode(0, QHeaderView::Stretch);

I think you should let the first column stretch (after resizing it to 200), and additionally, prevent the last one from straching, using:
line82+
      torrentContentList->header()->setStretchLastSection(0);

Or additionally, you could resize the last two columns to fit the content, and then make the first column stretch. Or you could just leave those two columns fixed.

By the way, I'd still like to be able to sort that tree view, i.e. to give smaller files a higher priority.

And it would be nice be able to expand/collapse subdirectiries, not just the root directory.

Nice wishlist, I suppose :)

[attilaolah (attilaolah)]

Also, I have some complains about the GUI... I think that rootIsDecorated should be set to 0, and allColumnsShowFocus should be set to true on both upload and download tabs, since they're not expandable.

BTW, is this the right place to discuss this?

[attilaolah (attilaolah)]

Also since the connection icon is now down in the status bar, I don't think we need that last separator in the toolbar.

You probably have better things to to do than to constantly update the GUI, so I could provide you diffs if you approve the changes.

Sorry for the dozens of bug reports. This will be the last one for tonight. I'll go to sleep now :)

[Christophe Dumez (hydr0g3n)]

aatis > I fixed all reported problem and v1.3.4 should be ok. Thanks for the reports.

[Christophe Dumez (hydr0g3n)]

v1.3.4 was released.

[attilaolah (attilaolah)]

Thanks, I'll check it out. Keep up the good work, Chris.