undercloud install fails with non-default template path

[Steven Hardy]

Deployment failed.
Command '['sudo', 'openstack', 'tripleo', 'deploy', '--standalone', '--standalone-role', 'Undercloud', '--stack', 'undercloud', '--local-domain=localdomain', '--local-ip=192.168.122.218/8', '--templates=/home/stack/tripleo-heat-templates', '--heat-native', '-e', '/home/stack/tripleo-heat-templates/environments/docker.yaml', '-e', '/home/stack/tripleo-heat-templates/environments/undercloud.yaml', '-e', '/home/stack/tripleo-heat-templates/environments/services/ironic.yaml', '-e', '/home/stack/tripleo-heat-templates/environments/services/ironic-inspector.yaml', '-e', '/home/stack/tripleo-heat-templates/environments/services/mistral.yaml', '-e', '/home/stack/tripleo-heat-templates/environments/services/zaqar.yaml', '-e', '/home/stack/tripleo-heat-templates/environments/services/tripleo-ui.yaml', '-e', '/home/stack/tripleo-heat-templates/environments/services/tempest.yaml', '-e', '/home/stack/tripleo-heat-templates/environments/public-tls-undercloud.yaml', '--public-virtual-ip', '192.168.24.2', '--control-virtual-ip', '192.168.24.3', '-e', '/home/stack/tripleo-heat-templates/environments/ssl/tls-endpoints-public-ip.yaml', '-e', '/home/stack/tripleo-heat-templates/environments/use-dns-for-vips.yaml', '-e', '/home/stack/tripleo-heat-templates/environments/services/undercloud-haproxy.yaml', '-e', '/home/stack/tripleo-heat-templates/environments/services/undercloud-keepalived.yaml', '--deployment-user', 'stack', '--output-dir=/home/stack', '--cleanup', '-e', '/home/stack/tripleo-config-generated-env-files/undercloud_parameters.yaml', '-e', '/home/stack/tripleo-heat-templates/environments/tripleo-validations.yaml', '-e', '/home/stack/containers.yaml', '--log-file=install-undercloud.log', '-e', '/usr/share/openstack-tripleo-heat-templates/undercloud-stack-vstate-dropin.yaml']

Can be reproduced like:

[stack@undercloud ~]$ cat run.sh
export THT_HOME=/home/stack/tripleo-heat-templates
time openstack undercloud install --use-heat \
| tee openstack_undercloud_deploy.out | lolcat

We're looking for
/usr/share/openstack-tripleo-heat-templates/undercloud-stack-vstate-dropin.yaml']

Which doesn't exist, so the install fails.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/582580

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/582916

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/582580
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=6ed0955049cd7ae7b11a0a5ae8ab167d1c8d3d9c
Submitter: Zuul
Branch: master

commit 6ed0955049cd7ae7b11a0a5ae8ab167d1c8d3d9c
Author: Steven Hardy <email address hidden>
Date: Fri Jul 13 15:01:33 2018 +0100

    Respect THT_HOME for vstate dropin file

    Currently this points to /usr/share even when THT_HOME is set.

    Change-Id: I000e8e9c101a9b1e0568b192e02938f83de128f9
    Closes-Bug: #1781600

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: master
Review: https://review.openstack.org/582916
Reason: this does not fit the model of --templates designed cases, which is

1. --templates (no args, uses default /usr/share location)
2. --templates foo (foo must exist, so we use it)

also, there was a -compat RPM for exactly this purpose (diverging the mixed tht paths) a while back

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 10.4.0 release.