5.0.1: BGPaaS local-as. Logging needed for local-as config and changes in control.log and sandesh

[Shashikiran H]

ocata-master-153

TOPO is as in Bug 1781172
Problem: If I change local-as for either bgpaas object's local-as or bgp router object's local-as created for bgpaas, there is no logging currently.

Need logging on control.log and sandesh messages about setting of the local-as and changes to bgpaas object local-as and changes to the BGP router object for bgpaas.

Changing global-as logs it correctly though. I see the below message on change in control.log for global-local-as:
2018-07-13 Fri 04:39:39:832.052 UTC nodec15 [Thread 139645950084864, Pid 1]: BGP [SYS_NOTICE]: BgpConfigNoticeLog: Updated Local Autonomous System from 64560 to 64561 controller/src/bgp/bgp_server.cc 267

[Narendranath (nkarjala)]

Hi Shashikiran

I've added related logs for logging "AS" updates. Could you please try the binaries in your setup.
Following are details for the binaries (R5.0)

Host:
ubuntu-build04 [ubuntu-build04.contrail.juniper.net]

Path
/build/nkarjala/BINARIES/BGPasS-LOG/R5.0

Files (Binary):
[nkarjala@ubuntu-build04]$md5sum contrail-control contrail-vrouter-agent
ed583cec4c0bc406e50ce6646c26aafa contrail-control
ae4c8bc012c97b5f87d23209fda025d8 contrail-vrouter-agent

Thanks
Naren

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/44726
Submitter: Narendranath (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/44726
Committed: http://github.com/Juniper/contrail-controller/commit/7669f8acb46eba762f31210d2bff6e4390556280
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 7669f8acb46eba762f31210d2bff6e4390556280
Author: Naren Karjala <email address hidden>
Date: Tue Jul 17 18:34:08 2018 -0700

Provide logging for the AS updates in config

Added BGP logging support for changes in AS.
Closes-Bug: 1781531

Change-Id: I81bccf678913a2525d9a4d933e8577aad354bca8

[Shashikiran H (skiranh)]

The logging in binaries for master branch work.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/45418
Submitter: Narendranath (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/45418
Committed: http://github.com/Juniper/contrail-controller/commit/2b6c717692fedc7d4e52e6895ef116a46e4f6ec4
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 2b6c717692fedc7d4e52e6895ef116a46e4f6ec4
Author: Naren Karjala <email address hidden>
Date: Tue Jul 17 18:34:08 2018 -0700

Provide logging for the AS updates in config (R5.0)

Added BGP logging support for changes in AS.
Closes-Bug: 1781531

Change-Id: I81bccf678913a2525d9a4d933e8577aad354bca8
(cherry picked from commit 7669f8acb46eba762f31210d2bff6e4390556280)