Juniper Openstack

Intent Compiler should use DependencyProcessor

Bug #1781195 reported by Witaut Bajaryn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
Medium
Witaut Bajaryn
Juniper Openstack r5.1.0

Bug Description

Intent Compiler should trigger events for all dependent resources for an event.

DependencyProcessor returns all dependent resources for a resource (by looking at its references), but it is not used anywhere. Make Intent Compiler use it.

Tags: atom
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/44523
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44522
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44521
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44520
Submitter: Witaut Bajaryn (<email address hidden>)

Witaut Bajaryn (vozhyk-)
information type: Proprietary → Private
information type: Private → Public
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44523
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44522
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44521
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44520
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44523
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44522
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44523
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44522
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44523
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44531
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44523
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44531
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44523
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44522
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44520
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44531
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44523
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44531
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44552
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44523
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/44520
Committed: http://github.com/Juniper/contrail/commit/9dd201c350537e06bd5ef0709cbe98d97c61dd37
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 9dd201c350537e06bd5ef0709cbe98d97c61dd37
Author: Witaut Bajaryn <email address hidden>
Date: Fri Jun 15 16:56:29 2018 +0200

dependencies_test: Check all resources are returned

Instead of just printing the result.
Remove unnecessary logging.

Also, add a test for returning the resource itself
when no references / other resources are present.

Partial-Bug: #1781195
Change-Id: I5bb858ff94fc88176d63d0144c7bf9724087332c

Jeba Paulaiyan (jebap)
tags: added: atom
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/44522
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44523
Submitter: Witaut Bajaryn (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/44522
Committed: http://github.com/Juniper/contrail/commit/e1556d3776eca23476b8e6284014f78ea73d08fa
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit e1556d3776eca23476b8e6284014f78ea73d08fa
Author: Witaut Bajaryn <email address hidden>
Date: Tue Jul 10 17:29:55 2018 +0200

Extract etcd.ParseEvent

Partial-Bug: #1781195
Change-Id: I003122bc80895f039ba47cd54d15e58a37eb6e51

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/44523
Committed: http://github.com/Juniper/contrail/commit/cde49cce62f679435f17a0f75ee71883c6ff16c3
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit cde49cce62f679435f17a0f75ee71883c6ff16c3
Author: Witaut Bajaryn <email address hidden>
Date: Fri Jul 6 20:11:28 2018 +0200

compilationif: Use etcd.ParseEvent

So that the logic for parsing an ETCD change into a request
is not duplicated.

Partial-Bug: #1781195
Change-Id: Ib29e675955e6a8dbc68950fc5728e80bbe11d5c4

Revision history for this message
Witaut Bajaryn (vozhyk-) wrote :

This has been resolved with https://review.opencontrail.org/#/c/45172, https://review.opencontrail.org/#/c/45695/, https://review.opencontrail.org/#/c/45012. This bug should be closed.

Revision history for this message
Witaut Bajaryn (vozhyk-) wrote :

This has been resolved with https://review.opencontrail.org/#/c/45172, https://review.opencontrail.org/#/c/45695/, https://review.opencontrail.org/#/c/45012.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.