pcbnew: Escape does not de-select nets

[ToddA]

Using modern toolset, Pcbnew gets stuck in dim state. Only way to return to standard brightness is using Inspect-> List Nets -> then hitting the cancel button in the dialog box.
Dimming can be reproduced by opening the list nets tool then pressing okay. Screen remains dim, except for highlighted nets.

Application: kicad
Version: (5.0.0-rc3-dev), release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Seth Hillbrand (sethh)]

Use Ctrl+Left click to de-select the net.

It may make sense to allow Escape to do this as well in the future.

[John Beard (john-j-beard)]

In a way I think it's good that Esc doesn't remove net highlighting, as I often press Esc just to ensure I'm in "normal" mode (probably a reflex from over-use of Vim!), and it might be annoying to have to re-highlight nets.

However, Ctrl-Left click certainly not an obvious way to escape the highlight mode when in normal mode, especially as the same thing in Highlight mode is Left click without Ctrl.

[Seth Hillbrand (sethh)]

Fixed in 518b53f78