NTP implementation hard-coded

[Paul Gear]

In https://github.com/openstack/charm-ceph-osd/blob/master/lib/ceph/utils.py#L84 and https://github.com/openstack/charm-ceph-osd/blob/master/lib/ceph/utils.py#L2599, the package name 'ntp' is hard-coded into the ceph-osd charm.

The same exists in https://github.com/openstack/charm-ceph-mon/blob/master/lib/ceph/utils.py#L84 and https://github.com/openstack/charm-ceph-mon/blob/master/lib/ceph/utils.py#L2613 in the ceph-mon charm.

Per lp:1744072, ntp has been demoted to universe and no longer receives full security support and chrony is the preferred NTP implementation for bionic and later. I think references to either package should be removed from the ceph charms.

[Paul Gear (paulgear)]

If ~openstack-charmers prefer, I'm happy to mark this as a duplicate of lp:1744072 and discuss further options there.

[Nicolas Pochet (npochet)]

The proposed implementation is to remove ntp package reference from both charms.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/584023

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/584051

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/584255
Committed: https://git.openstack.org/cgit/openstack/charms.ceph/commit/?id=afdd9a974d630abdcea87f0b048d56c1bd4bb7ea
Submitter: Zuul
Branch: master

commit afdd9a974d630abdcea87f0b048d56c1bd4bb7ea
Author: Nicolas Pochet <email address hidden>
Date: Fri Jul 20 09:02:49 2018 +0200

    Remove reference to ntp package

    This is motivated by the fact that:
    * the ntp/chrony package is already a dependency of the ceph-mon/osd
    package
    * NTP will be managed by operators through the NTP charm
    It is thus useless to keep that package mentioned here.

    Change-Id: Iddb7ffcc7ab7a74700855b950f619208511c2fab
    Closes-Bug: #1780690

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/584023
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-osd/commit/?id=bb3a7f198ca94b77b7a1b3c06df117633564f2c5
Submitter: Zuul
Branch: master

commit bb3a7f198ca94b77b7a1b3c06df117633564f2c5
Author: Nicolas Pochet <email address hidden>
Date: Thu Jul 19 15:08:39 2018 +0200

    Remove reference to ntp package

    This is motivated by the fact that:
    * the ntp/chrony package is already a dependency of the ceph-mon/osd
    package
    * NTP will be managed by operators through the NTP charm
    It is thus useless to keep that package mentioned here.

    Change-Id: I5834ff22d4306707529e958cd26f14bbb752c796
    Closes-Bug: #1780690
    Depends-on: Iddb7ffcc7ab7a74700855b950f619208511c2fab

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/584051
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-mon/commit/?id=37fbda6bd89090a15f03ae38372f93373a240cb0
Submitter: Zuul
Branch: master

commit 37fbda6bd89090a15f03ae38372f93373a240cb0
Author: Nicolas Pochet <email address hidden>
Date: Thu Jul 19 18:45:26 2018 +0200

    Remove reference to ntp package

    This is motivated by the fact that:
    * the ntp/chrony package is already a dependency of the ceph-mon/osd
    package
    * NTP will be managed by operators through the NTP charm
    It is thus useless to keep that package mentioned here.

    Change-Id: If6ecfc6f515bec4f955a5b52df8f0fbfafd29008
    Closes-Bug: #1780690
    Depends-on: Iddb7ffcc7ab7a74700855b950f619208511c2fab