wrong fluentd containers log paths

[Juan Badia Payno]

Fluentd is configured incorrectly.

The services have a wrong path.
Service log path should be something like /var/log/containers/SERVICE and is set /var/log/containers/containers/SERVICE

This behavior can be seen on the gate, for example http://logs.openstack.org/97/579697/1/check/tripleo-ci-centos-7-scenario001-multinode-oooq-container/16ae389/logs/subnode-2/var/log/config-data/fluentd/etc/fluentd/config.d/100-openstack-ceilometer_agent_central.conf.txt.gz

********* The content of the above link ***************************************
# This file is managed by Puppet, do not edit manually.
<source>
  format /(?<time>\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}.\d+) (?<pid>\d+) (?<priority>\S+) (?<message>.*)$/
  path /var/log/containers/containers/ceilometer/central.log
  pos_file /var/cache/fluentd/openstack.ceilometer.agent.central.pos
  tag openstack.ceilometer.agent.central
  @type tail
</source>
********************************************************************************

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/580102

[Cédric Jeanneret (cjeanner)]

Good catch - but I think we'd rather avoid reverting the whole thing as proposed today.

Some people might still want to get the right log location in the hieradata content, while NOT using fluentd.
Of course, they can set the transform thingy by themselves, but I don't think this is the right way to do that.

Having the capacity to override the log location is interesting, but by default, in any conditions, tripleo should set them right, fluentd involved or not.

The best way to achieve that would be to just drop the call to the transform from the fluentd service definition file, here:
https://github.com/openstack/tripleo-heat-templates/blob/master/docker/services/fluentd.yaml#L63

Dropping those three lines will allow to:
- still get the right default location whenever we have fluentd or not
- still allow people to override the log location if needed/wanted

What do you think?

Cheers,

C.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Juan Badia Payno (<email address hidden>) on branch: master
Review: https://review.openstack.org/580102

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/580193

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/580193
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b0a27757c4e7fb7236fc1f9c67db13b6d5ad7ed6
Submitter: Zuul
Branch: master

commit b0a27757c4e7fb7236fc1f9c67db13b6d5ad7ed6
Author: Juan Badia Payno <email address hidden>
Date: Wed Jul 4 17:03:19 2018 +0200

    Fluentd: disable log path docker transformation

    Currently fluentd is using a path transformation to set the log
    path on all the docker services. This transformation creates
    /var/log/containers path from /var/log, so all the log paths are
    configured wrongly as /var/log/containers/containers/

    This path disables the transformation on the fluentd service.

    Closes-Bug: #1780050

    Change-Id: I07374da9ddbd61f9feb2a17dcbe4514f43d70457

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b4 development milestone.