Cinder's db sync should only be performed on bootstrap node

[Alan Bishop]

The puppet-tripleo code that handles the ::cinder::api resource is not specifying a value for the $sync_db class parameter, and the ::cinder::api class defaults this to True. As a consequence, in an HA environment, Cinder's db sync is performed on all nodes, regardless of whether it is the bootstrap node.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/579234

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/579234
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=34810fc361e71cfabe5d8ad6e083c664af9120e8
Submitter: Zuul
Branch: master

commit 34810fc361e71cfabe5d8ad6e083c664af9120e8
Author: Alan Bishop <email address hidden>
Date: Thu Jun 28 09:41:58 2018 -0400

    Run cinder's db sync only on bootstrap node

    The sync_db variable (which is True only on bootstrap node) needs to be
    passed to the ::cinder::api resource to ensure the db sync only happens
    on the bootstrap node.

    Closes-Bug: #1779112
    Change-Id: Ib7fcafbe769aadfcc58323ba3a06fa28a80a488a

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/579732

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: stable/queens
Review: https://review.openstack.org/579732
Reason: The gate is suffering of timeouts, we need to clear it. Please do not restore or recheck this patch, I'll take care of it when gate is stable again.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/579732
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=690bf10462d2ac922e8c22631320e359cba9698f
Submitter: Zuul
Branch: stable/queens

commit 690bf10462d2ac922e8c22631320e359cba9698f
Author: Alan Bishop <email address hidden>
Date: Thu Jun 28 09:41:58 2018 -0400

    Run cinder's db sync only on bootstrap node

    The sync_db variable (which is True only on bootstrap node) needs to be
    passed to the ::cinder::api resource to ensure the db sync only happens
    on the bootstrap node.

    Closes-Bug: #1779112
    Change-Id: Ib7fcafbe769aadfcc58323ba3a06fa28a80a488a
    (cherry picked from commit 34810fc361e71cfabe5d8ad6e083c664af9120e8)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/580360

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/580360
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=a5cc194f63aecaea32cb3e03ae5b74b05103668f
Submitter: Zuul
Branch: stable/pike

commit a5cc194f63aecaea32cb3e03ae5b74b05103668f
Author: Alan Bishop <email address hidden>
Date: Thu Jun 28 09:41:58 2018 -0400

    Run cinder's db sync only on bootstrap node

    The sync_db variable (which is True only on bootstrap node) needs to be
    passed to the ::cinder::api resource to ensure the db sync only happens
    on the bootstrap node.

    Closes-Bug: #1779112
    Change-Id: Ib7fcafbe769aadfcc58323ba3a06fa28a80a488a
    (cherry picked from commit 34810fc361e71cfabe5d8ad6e083c664af9120e8)
    (cherry picked from commit 690bf10462d2ac922e8c22631320e359cba9698f)
    Conflicts:
     manifests/profile/base/cinder/api.pp
     spec/classes/tripleo_profile_base_cinder_api_spec.rb

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 9.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 7.4.15 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 8.3.5 release.