Pcbnew drill dialog does not close on escape key

[Wayne Stambaugh]

I've tried all of the usual methods to get the escape key to close the Pcbnew generate drill file dialog. I'm pretty sure this used to work. Any ideas as to why this doesn't work with this dialog?

Application: kicad
Version: (5.0.0-rc2-208-g7eea8f808-dirty), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.59.0 OpenSSL/1.0.2o (WinSSL) zlib/1.2.11 brotli/1.0.4 libidn2/2.0.5 nghttp2/1.32.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.59.0
    Compiler: GCC 7.3.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

This is because the dialog itself somehow got the ID wxID_CANCEL, so when EmulateButtonClickIfPresent() tries to find the Cancel button it gets the dialog instead, and then the dynamic cast to button returns NULL.

[Jeff Young (jeyjey)]

(Fixed in my 6.0 a.k.a. 5.1 tree.)

[Wayne Stambaugh (stambaughw)]

@Jeff, I totally missed the fact the dialog ID was set to wxID_CANCEL. How much trouble would it be to the fix for rc3? It seems like a fairly trivial fix. The only reason that I set the milestone to 5.1 is that I thought it might be a more intrusive fix. The some goes for the netlist dialog as well.

[Jeff Young (jeyjey)]

It's a no-brainer to fix. I'll push it to rc3.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 246a9286a996c7bafe57d3948021d1852411108a
https://git.launchpad.net/kicad/patch/?id=246a9286a996c7bafe57d3948021d1852411108a