open-ils.circ.checkout.full log_me() uses legacy arg for copy barcode

[Josh Stompro]

EG 2.10 and 3.1

http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm#l3960

The log_me sub uses the following to populate the $bc variable, which is supposed to be the copy barcode.

3962 my $bc = ($self->copy) ? $self->copy->barcode :
3963 $self->barcode;
3964 $bc ||= "";

But I believe that $self->barcode should actually be $self->copy_barcode, if the goal is to report on the barcode that was passed into open-ils.circ.checkout.full

The translate_legacy_args sub seems to look for arguments named barcode and change it to copy_barcode. I don't see that $self->barcode/$circulator->barcode is used anywhere but in the log_me sub.
http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm#l339

I would like to have a log of attempted checkouts, with whatever barcode is entered by the user. Currently the '$self->log_me("do_permit()");' call will only report the barcode if it exists in asset.copy, but I think the goal was to report whatever barcode was entered. I think when the translate_legacy_args was created the log_me sub just wasn't updated.

Josh

[Josh Stompro (u-launchpad-stompro-org)]

Working branch at user/stompro/lp1778783_circulate_log_me_barcode
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1778783_circulate_log_me_barcode

Josh

[Bill Erickson (berick)]

Issue and fix confirmed. A handy debugging improvement. Thanks, Josh!