Quality of Service (QoS) in Neutron - associating QoS policy to Floating IP

Bug #1778740 reported by Arkady Shtempler
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Slawek Kaplonski

Bug Description

### Bug in documentation ###
https://docs.openstack.org/neutron/queens/admin/config-qos.html

1) Commands’ order
“The QoS bandwidth limit rules attached to a floating IP will become active when you associate the latter with a port. For example, to associate the previously created floating IP 172.16.100.12 to the instance port with fixed IP 192.168.222.5:”
After the above sentence we have “openstack port show a7f25e73-4288-4a16-93b9-b71e6fd00862” command, why?
This “SHOW” command shows port’s details only, but next command “openstack floating ip set --port a7f25e73-4288-4a16-93b9-b71e6fd00862 0eeb1f8a-de96-4cd9-a0f6-3f535c409558” does the associating, so it’s seems to me that commands’ order must be changed. Also by doing that we can point out user that “qos_policy_id” value in “Show” output has valid ID, means that associating is done as expected.

2) Unknown ID “0eeb1f8a-de96-4cd9-a0f6-3f535c409558”
As potential user, I would expect to see one of the the IDs received in “openstack floating ip list” command’s output as parameter for “openstack floating ip set ...”, but actually we have “0eeb1f8a-de96-4cd9-a0f6-3f535c409558” and we don’t have such ID in our Floating IP list.

description: updated
tags: added: qos
Revision history for this message
Slawek Kaplonski (slaweq) wrote :

Ad. 1.
About order of commands I don't think it's wrong. SHOW command is there only to show port to which FIP will be later associated, nothing else. Why You think it can't/shouldn't be done before association?

Ad. 2.
I agree, it should be FIP with uuid=d0ed7491-3eb7-4c4f-a0f0-df04f10a067c in "openstack floating ip set " used.

tags: added: low-hanging-fruit
Changed in neutron:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Arkady Shtempler (ashtempl) wrote :

1# If so it must be "openstack port list" where you can get the Port_ID of relevant port and to use this Port_ID later on associating.

I think that using show command will make sense only when we want to point out, that "qos_policy_id" is set to "None" before associating (QoS disabled) and changed to "Valid ID" (QoS enabled) after associating.
To do that we'll need to elaborate as follow:

1) openstack port list --> to get <Port_ID> of relevant port
2) openstack show <Port_ID> --> will contain "qos_policy_id:None" (QoS disabled)
3) openstack floating ip set --port <Port_ID> <FIP>
4) openstack show <Port_ID> --> now will contain "qos_policy_id:VALID_ID_STRING" (QoS enabled)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/591619

Changed in neutron:
assignee: nobody → Slawek Kaplonski (slaweq)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/591619
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8ed2ba87984edad163dea69688f1d7d71f1e119a
Submitter: Zuul
Branch: master

commit 8ed2ba87984edad163dea69688f1d7d71f1e119a
Author: Slawek Kaplonski <email address hidden>
Date: Tue Aug 14 12:37:00 2018 +0200

    Update FIP QoS Docs

    This patch updates QoS docs to remove "port show" command
    before associating Floating IP to port.
    It is like that to be clear that QoS policy which is attached to
    the FloatingIP is NOT visible in the port's attributes.

    Change-Id: I127fbd25433e39905c3b83bbe914f027ab45ef3f
    Closes-Bug: #1778740

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 14.0.0.0b1

This issue was fixed in the openstack/neutron 14.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.