No "reset to defaults" ability in PCB Calculator, so important values can be easily lost

Bug #1778116 reported by Gabriel Staples
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
Wishlist
Dmitry Rezvanov

Bug Description

Application: kicad
Version: 5.0.0-rc2-dev-unknown-f73b9a5~65~ubuntu14.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.35.0 OpenSSL/1.0.1f zlib/1.2.8 libidn/1.28 librtmp/2.3
Platform: Linux 4.4.0-112-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.54.0
    Curl: 7.35.0
    Compiler: GCC 4.8.4 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

--------------------------

In the PCB Calculator, Track Width, for example, if you change the Resistivity value from 1.72e-8 (accidentally) to something else, or delete it, there's no way to know what it should be anymore, and no way to reset it to defaults. This can be solved in a number of ways.

Ex:
1. Add a button to "reset to default values"
2. Add a right-click option to "reset to default value" when you click in any entry box
3. Add a list of the default values in the white information box so that the user can see the default values and simply type them back in themselves if they want to.

Note that this fix should be applied to all of the calculator tabs for any input value that has a default value.

Revision history for this message
Gabriel Staples (ercaguy) wrote :
description: updated
tags: added: pcb-calculator
Changed in kicad:
importance: Undecided → Wishlist
tags: added: starter
Revision history for this message
Gabriel Staples (ercaguy) wrote :

Note that this "reset to default" addition would also be very much appreciated in other places in KiCad, such as in the "Copper Zone Properties" window in Pcbnew. Otherwise, it's super easy as a beginner to change these settings and then not know what are good defaults afterwards. A "reset to defaults" button or something would be really nice inside this window (see attached image) and all other windows where defaults are present.

Revision history for this message
Dmitry Rezvanov (misaka10032) wrote :

I tried to create patch for this wish.
As far I understand, TransLine and RF Attenuator don't save parameters between launches.
But I don't have any idea, why wxFormBuilder changes form file so much.

I hope for providing any feedback.

Revision history for this message
Ian McInerney (imcinerney) wrote :

Dmitry, thank you for the patch.

There are three issues that I see with it though:

1) On the regulators tab, when you reset to the defaults it doesn't reset the picture when the regulator type changes (it changes the dropdown selection but not the picture).

2) I believe the button text should be "Reset to Defaults" (since we are resetting more than one thing, the plural form sounds better).

3) Please follow this format for your commit message: http://docs.kicad-pcb.org/doxygen/commit_messages.html
currently you have a line that is too wide.

After those changes it will be ready to be merged.

Changed in kicad:
assignee: nobody → Dmitry Rezvanov (misaka10032)
milestone: none → 6.0.0-rc1
Revision history for this message
Ian McInerney (imcinerney) wrote :

Also, I think it would be useful to have a reset to defaults on the transmission line calculator. Even if it doesn't save them between launches, it would allow you to recover the default values without having to relaunch the PCB calculator. If you want to add that you can, but we can still merge your patch with the above changes without the transmission line part if you prefer.

Revision history for this message
Dmitry Rezvanov (misaka10032) wrote :

Ian, thank you for feedback.
Yes, you're absolutely right.
In new patch I'll fix your three issues and add a reset on the transmission line calculator.

Revision history for this message
Dmitry Rezvanov (misaka10032) wrote :

Ian, I think, I fixed your issues.

Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 9c33620a0fcf8e7c1f23bfacea6c89da1108199f
https://git.launchpad.net/kicad/patch/?id=9c33620a0fcf8e7c1f23bfacea6c89da1108199f

Changed in kicad:
status: New → Fix Committed
Revision history for this message
Ian McInerney (imcinerney) wrote :

Dmitry, thanks for updating the patch. It looks good to me, so I have merged it into the v6 development.

Thank you for your contribution!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.