Left-over ceph.conf alternative

[Peter Sabaini]

When adding a ceph-mon rel to cinder, the charm installs ceph.conf with the alternatives system ( update-alternatives --install, called via cinder_utils.resource_map())

However upon rel departure that alternative is not cleaned up. That can cause issues if installing a cinder-ceph subord. This charm installs a ceph.conf alternative as well, but as it's at the same prio the alternatives system still points to the old ceph.conf.

[Chris MacNaughton (chris.macnaughton)]

What version of the charm is this on? The latest version should handle cleanup of the installed alternatives file: https://github.com/openstack/charm-cinder/blob/master/hooks/cinder_utils.py#L281

[Peter Sabaini (peter-sabaini)]

These charms are at 17.02. ICBW, but I don't see a call to remove_alternative() in HEAD though?

[Launchpad Janitor (janitor)]

[Expired for OpenStack cinder-ceph charm because there has been no activity for 60 days.]

[Xav Paice (xavpaice)]

This was marked incomplete, could you clarify what information is needed?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/620102

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/620102
Committed: https://git.openstack.org/cgit/openstack/charm-cinder-ceph/commit/?id=18cbf7f6e1642d15d18c500c3e61f9106159e176
Submitter: Zuul
Branch: master

commit 18cbf7f6e1642d15d18c500c3e61f9106159e176
Author: Syed Mohammad Adnan Karim <email address hidden>
Date: Mon Nov 26 15:40:21 2018 +0000

    Update hook to remove old ceph.conf alternatives

    When adding ceph-mon relation to cinder, the charm installs ceph.conf
    with the update-alternatives via cinder_utils.resource_map().
    However when the relation is removed, the alternative isn't cleaned up.
    This can cause issues if installing a cinder-ceph subordinate charm.
    The cinder-ceph charm also installs a ceph.conf alternative that will
    point to the leftover ceph.conf installed by the ceph-mon charm.

    Added remove_alternative() in ceph-relation-broken hook to ensure
    that leftover ceph.conf alternatives is removed upon relation removal.

    Change-Id: I308e62a626f31eb8ef690a09035fe3908920ccc9
    Closes-Bug: 1778084

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/621595

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/621595
Committed: https://git.openstack.org/cgit/openstack/charm-cinder-ceph/commit/?id=2378c424ee966f73e046499913605ce4b1e5e9d6
Submitter: Zuul
Branch: master

commit 2378c424ee966f73e046499913605ce4b1e5e9d6
Author: Syed Mohammad Adnan Karim <email address hidden>
Date: Sat Dec 1 00:50:54 2018 +0000

    Adds amulet test - ceph.conf alternatives removal

    Test checks for the removal of ceph.conf alternatives when ceph-mon
    relation is broken. If ceph.conf is not present when the relation is
    still joined, the test fails. If ceph.conf is not removed after the
    relation is broken, the test fails. The test will pass if an existing
    ceph.conf file is removed after the ceph-mon relation is broken.

    Change-Id: I3b348a58bd2e3ebbbecbd3bbb4307c490a0c4ea4
    Related-Bug: 1778084

[Drew Freiberger (afreiberger)]

Syed/James,

This needs to be pathced in charm-cinder as well. charm-cinder-ceph is the one that joins relation, not departs in this upgrade path from cinder->ceph to cinder->cinder-ceph->ceph.

[Xav Paice (xavpaice)]

Added field-critical. The move of relation from cinder to cinder-ceph, and the resulting empty ceph.conf, affects production environments where we've had to work around this with manual updates.

[Xav Paice (xavpaice)]

Manual workaround was to copy /var/lib/charm/cinder/ceph.conf to /var/lib/charm/cinder-ceph/ceph.conf plus fix alternatives to have only the one option:

update-alternatives --query ceph.conf

Name: ceph.conf
Link: /etc/ceph/ceph.conf
Status: auto
Best: /var/lib/charm/cinder-ceph/ceph.conf
Value: /var/lib/charm/cinder-ceph/ceph.conf

Alternative: /var/lib/charm/cinder-ceph/ceph.conf
Priority: 50

update-alternatives --config ceph.conf
There is only one alternative in link group ceph.conf (providing /etc/ceph/ceph.conf): /var/lib/charm/cinder-ceph/ceph.conf
Nothing to configure.

[Chris MacNaughton (chris.macnaughton)]

Xav, this is in charm-cinder already: https://github.com/openstack/charm-cinder/blob/master/hooks/cinder_hooks.py#L447

[Chris MacNaughton (chris.macnaughton)]

This change exists at master, and has now been proposed for a backport in https://review.openstack.org/#/c/634867/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/634867
Committed: https://git.openstack.org/cgit/openstack/charm-cinder/commit/?id=d2b9569d72db8b29e5e2439eda26f0ac05adb406
Submitter: Zuul
Branch: stable/18.11

commit d2b9569d72db8b29e5e2439eda26f0ac05adb406
Author: Syed Mohammad Adnan Karim <email address hidden>
Date: Mon Nov 26 16:30:22 2018 +0000

    Update hook to remove old ceph.conf alternatives

    When adding ceph-mon relation to cinder, the charm installs ceph.conf
    with the update-alternatives via cinder_utils.resource_map().
    However when the relation is removed, the alternative isn't cleaned up.
    This can cause issues if installing a cinder-ceph subordinate charm.
    The cinder-ceph charm also installs a ceph.conf alternative that will
    point to the leftover ceph.conf installed by the ceph-mon charm.

    Added remove_alternative() in ceph-relation-broken hook to ensure
    that leftover ceph.conf alternatives is removed upon relation removal.

    Change-Id: If9a8d460ee8209ef917fa55ec970379e9c741ec6
    Related-Bug: 1778084
    (cherry picked from commit e6a150c0d2894dadb870a4a356f1f9ab2336faa8)