undercloud password generation is not idempotent

[Alex Schultz]

When running subsequent undercloud installs, some of the passwords are being changed in the tripleo-undercloud-passwords.yaml

[root@undercloud ~]# diff old/tripleo-undercloud-passwords.yaml tripleo-undercloud-passwords.yaml
23a24
> HaProxyStatsPassword: mq0kaNSw16MmX0uVnkC9DeuNt
38a40
> LibvirtTlsPassword: BqqiGuEInkzrZTWHhuMm2uPOY
115c117
< RpcPassword: u5Ao6IEfHzuq4kMOhplTtRL1f
---
> RpcPassword: wPbrlqH2b64RrCUp5tgSZNudy

The undercloud-passwords.conf is also not idempotent

[root@undercloud ~]# diff old/undercloud-passwords.conf undercloud-passwords.conf
2,4d1
< undercloud_rpc_password: u5Ao6IEfHzuq4kMOhplTtRL1f
< undercloud_manila_password: yNMlDdaWh13eWHBRGkJsLWZGG
< undercloud_neutron_password: MUJdgbbbEZtohpVDmlCGrhAOC
6,8c3,6
< undercloud_snmpd_readonly_user_password: Jq3jAUSAsZTFO13a0oSuP37GO
< undercloud_heat_password: HHBZFm0u5grInyLe9oGfdbYoy
< undercloud_barbican_password: zTvc4PsETDssWjEKiYVfyEDVf
---
> undercloud_rpc_password: wPbrlqH2b64RrCUp5tgSZNudy
> undercloud_neutron_password: MUJdgbbbEZtohpVDmlCGrhAOC
> undercloud_barbican_simple_crypto_kek: tjAMLpNJvZtgligppwfLdw8oSu1juPy9LKzdhFIyKQk=
> undercloud_glance_password: eZr3Y5lvTQyi642NVNdMm00j6
10,12c8,9
< undercloud_heat_stack_domain_admin_password: E3aK1otbQONG2eo34ELQENowK
< undercloud_zaqar_password: mcWvoc6MGT9yfsjFKluqnpJiV
< undercloud_pcsd_password: drDqlKTVauw5N8uR
---
> undercloud_notify_password: ypZphvzqIHMNF43rPw7AS6tGP
> undercloud_nova_password: 3OwBJJQpC40OdR8ouCp0vdh6g
15,17d11
< undercloud_notify_password: ypZphvzqIHMNF43rPw7AS6tGP
< undercloud_glance_password: eZr3Y5lvTQyi642NVNdMm00j6
< undercloud_ec2_api_password: OF1REROY7j3U0tC2ntAN9KRw5
19c13
< undercloud_ceilometer_password: rm0sMfA5D47tmV81orf2WlzKI
---
> undercloud_ec2_api_password: OF1REROY7j3U0tC2ntAN9KRw5
21a16
> undercloud_ha_proxy_stats_password: mq0kaNSw16MmX0uVnkC9DeuNt
23,29d17
< undercloud_trove_password: 8FovmHp69p7prmulWuVqUcosk
< undercloud_tacker_password: MVYrvAPpmf9ytCdxc1Xzs5USi
< undercloud_aodh_password: zVXaxp8qg7rOGhmsZN6EuJEbK
< undercloud_designate_password: LAfpWWHk5ezGZiQAfzDafonda
< undercloud_barbican_simple_crypto_kek: tjAMLpNJvZtgligppwfLdw8oSu1juPy9LKzdhFIyKQk=
< undercloud_etcd_initial_cluster_token: jrreew1dsjCIn2mNV2X46utQs
< undercloud_nova_password: 3OwBJJQpC40OdR8ouCp0vdh6g
31d18
< undercloud_redis_password: rwESWXX8YCEun9muoXGMJd09F
32a20
> undercloud_tacker_password: MVYrvAPpmf9ytCdxc1Xzs5USi
33a22,24
> undercloud_swift_password: TjNkXBW2F42e3eLa2O9HL4wNF
> undercloud_barbican_password: zTvc4PsETDssWjEKiYVfyEDVf
> undercloud_octavia_password: IneBHHgsAuFaFZlKq5YTalj5v
36c27,39
< undercloud_swift_password: TjNkXBW2F42e3eLa2O9HL4wNF
---
> undercloud_libvirt_tls_password: BqqiGuEInkzrZTWHhuMm2uPOY
> undercloud_heat_password: HHBZFm0u5grInyLe9oGfdbYoy
> undercloud_snmpd_readonly_user_password: Jq3jAUSAsZTFO13a0oSuP37GO
> undercloud_heat_stack_domain_admin_password: E3aK1otbQONG2eo34ELQENowK
> undercloud_zaqar_password: mcWvoc6MGT9yfsjFKluqnpJiV
> undercloud_pcsd_password: drDqlKTVauw5N8uR
> undercloud_ceilometer_password: rm0sMfA5D47tmV81orf2WlzKI
> undercloud_trove_password: 8FovmHp69p7prmulWuVqUcosk
> undercloud_designate_password: LAfpWWHk5ezGZiQAfzDafonda
> undercloud_etcd_initial_cluster_token: jrreew1dsjCIn2mNV2X46utQs
> undercloud_redis_password: rwESWXX8YCEun9muoXGMJd09F
> undercloud_aodh_password: zVXaxp8qg7rOGhmsZN6EuJEbK
> undercloud_manila_password: yNMlDdaWh13eWHBRGkJsLWZGG
38d40
< undercloud_octavia_password: IneBHHgsAuFaFZlKq5YTalj5v

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/576990

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/576990
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=b5e5dd2c5f1eb56052be2b17124840170d8b6fd5
Submitter: Zuul
Branch: master

commit b5e5dd2c5f1eb56052be2b17124840170d8b6fd5
Author: Alex Schultz <email address hidden>
Date: Wed Jun 20 15:27:42 2018 -0600

    Fix undercloud password idempotency

    The libvirt tls, rabbit and haproxy stats passwords were getting
    duplicated or changed on subsequent runs. This change fixes the way we
    were handling the variables for these so they won't be overwritten.

    Change-Id: Iecc5e0638f9f43056e6474f8b2556009e8153d30
    Closes-Bug: #1777941

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/577809
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=62947ece560c3d0d6ea2b1702022f5185094a929
Submitter: Zuul
Branch: master

commit 62947ece560c3d0d6ea2b1702022f5185094a929
Author: Wes Hayutin <email address hidden>
Date: Mon Jun 25 08:57:11 2018 -0400

    turn off undercloud idempotency check on fs002

    Turns off undercloud idempotency check on fs002
    Turns on undercloud idempotency check in fs20 or
    periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset020-master

    Related-Bug: #1777939
    Related-Bug: #1777941
    Change-Id: Ib83aed5fa55a9deb6ac8a90817ad05d2f281dcb6

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 10.3.0 release.