Undo History of Linked Offset text crashes Inkscape

[prkos]

Clicking randomly in Undo history with Linked Offset of text crashes Inkscape. To reproduce:

1. create text (one letter will do)
2. Path > Linked Offset (moving handle isnt necessary)
3. open Undo History (Shift+Ctrl+H)
4. start clicking in the Undo History, redoing and undoing randomly

Inkscape will crash with an error message, see message in the screenshot. The number of clicks required for crash varies, it only happens with text objects.

Tested on WinXP, build from Dec 18th

[p0is0n (michael-jaeger-deactivatedaccount)]

There is another (similar) bug with the text field. To reproduce the crash it is important to draw a text box with the mouse to create the text field:

1. Create a textfield and put some text in
2. Create another textfield (without putting text in)
3. Click on the first textfield again and press "Undo" -> Crash!

Linux, 2008-02-07 (Version 0.45.1, Debian)

[Tom Davidson (tjd-mit)]

I can't reproduce either of these bugs in current SVN (rev 17256) under linux. The second one looks like bug 168908 ("Crashes upon undoing of text frame"), which is marked fixed as of Sep 25 2007.

Prkos can you see if the first one is still happening in current SVN for you? If possible, can you also paste the

[prkos (prkos)]

It still happens on WinXP 0.46pre1 built Feb 1st with the exact same message

I can download the latest daily version but I haven't had luck with gdb so far

[gustav_b (gustav-b)]

(I'm the one to blame for this bug.)

I've got all the information I need for this one (I'm able to reproduce it myself) and I have an experimental patch for it. It need some more testing/analysis, but hopefully I'll be able to commit it in time for 0.46.

(The bug mentioned by p0is0n is, as Tom said, not related to this one.)

[prkos (prkos)]

Thanx gustav_b :)

I don't know if this helps, I forgot to mention it before: in the History list an additional row appears that can be clicked. It appears after I start clicking below all the other actions. Its empty and it doesnt seem to be related to any action, and I've only noticed it in this linked offset text example.

[bbyak (buliabyak)]

Gustav, any news on this one? Did you commit your patch?

[bbyak (buliabyak)]

i can reproduce it in rev 19323, I get an "incomplete undo transaction" warning and then

** (inkscape:25430): CRITICAL **: virtual void Inkscape::EventLog::notifyRedoEvent(Inkscape::Event*): assertion `_getRedoEvent() && (*(_getRedoEvent()))[_columns.event] == log' failed

gtkmm-ERROR **: file treeiter.cc: line 214 (const Gtk::TreeNodeChildren& Gtk::TreeRow::children() const): assertion failed: (!is_end_)
aborting...

[jazzynico (jazzynico)]

I can reproduce it very easily on Windows XP with 0.46, 0.47 and 0.48.2, but not with the latest trunk (r10760). With older versions, it takes maximum 30-40 random clicks to trigger the crash. With the trunk, I've tried several hundreds clicks, and it's still running. Thus I guess the recent refactoring has fixed it.

Closing it fixed committed, but don't hesitate to reopen it if you run into that bug again with a trunk version.