fwts: not passing ADT testing

[Colin Ian King]

ADT tests are failing for fwts:

Setting up dkms (2.3-3ubuntu10) ...
Setting up fwts-efi-runtime-dkms (18.06.00-0ubuntu1) ...
Loading new fwts-efi-runtime-dkms-18.06.00 DKMS files...
Building for 4.15.0-23-generic
Building initial module for 4.15.0-23-generic
Error! The dkms.conf for this module includes a BUILD_EXCLUSIVE directive which
does not match this kernel/arch. This indicates that it should not be built.
Skipped.
Setting up fwts (18.06.00-0ubuntu1) ...
Setting up fwts-frontend (18.06.00-0ubuntu1) ...
Setting up autopkgtest-satdep (0) ...
Processing triggers for libc-bin (2.27-3ubuntu1) ...
(Reading database ... 98549 files and directories currently installed.)
Removing autopkgtest-satdep (0) ...
autopkgtest [10:19:11]: test command1: /usr/lib/dkms/dkms-autopkgtest
autopkgtest [10:19:11]: test command1: [-----------------------
dpkg: dependency problems prevent removal of dkms:
 fwts-efi-runtime-dkms depends on dkms (>= 2.1.0.0).

dpkg: error processing package dkms (--remove):
 dependency problems - not removing
Errors were encountered while processing:
 dkms
I: Installing binary package fwts
Reading package lists...
Building dependency tree...
Reading state information...
fwts is already the newest version (18.06.00-0ubuntu1).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
tar: Cowardly refusing to create an empty archive
Try 'tar --help' or 'tar --usage' for more information.
autopkgtest [10:19:12]: test command1: -----------------------]
autopkgtest [10:19:13]: test command1: - - - - - - - - - - results - - - - - - - - - -
command1 FAIL non-zero exit status 123
autopkgtest [10:19:13]: @@@@@@@@@@@@@@@@@@@@ summary
command1 FAIL non-zero exit status 123
Exit request sent.
Creating nova instance adt-cosmic-amd64-fwts-20180619-101749 from image adt/ubuntu-cosmic-amd64-server-20180619.img (UUID c20bc693-1f16-4b98-bc3a-c4751c0e4a86)...

[Colin Ian King (colin-king)]

I wonder if this is due to commit:

commit 04bc4d9a769f839a4baabc61573ff0c14c47ede7
Author: Alex Hung <email address hidden>
Date: Thu Jun 7 21:13:40 2018 -0700

    efi_runtime: build dkms for kernel that does not have efi_test

[Colin Ian King (colin-king)]

https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-cosmic/cosmic/amd64/f/fwts/20180619_101922_b969e@/log.gz

[Alex Hung (alexhung)]

It looks like trying to remove an installed fwts-efi-runtime-dkms package which needs not be installed in the first place.

This should only happen when upgrading fwts, not on a new system...

What is the ADT test about?

[Colin Ian King (colin-king)]

So just some notes. One can reproduce this using:

sudo autopkgtest ./fwts_18.06.00-0ubuntu1.dsc -- null

..this will build fwts and run the ADT tests. Note that this may leave artifacts in the directory and running this as root is not really a perfect idea.

http://packaging.ubuntu.com/html/auto-pkg-test.html has notes on how to run these tests in a virtualized environment, which is probably better.

Anyhow, I've reverted this commit for now, sent it to the fwts-mailing list, https://lists.ubuntu.com/archives/fwts-devel/2018-June/010528.html