Incorrect use of translation _()

[Morgan Fainberg]

Keystone uses translated strings both in logging an exceptions. This is incorrect.

All strings that are passed to logging should remain un-translated. The solution is to duplicate the string and pass the untranslated (not wrapped with `_()`) to the logger while passing the translated `_()` wrapped string to the exception.

Relevant Discussion: http://eavesdrop.openstack.org/irclogs/%23openstack-oslo/%23openstack-oslo.2018-06-18.log.html#t2018-06-18T22:03:19

[Colleen Murphy (krinkle)]

Is this actually a problem? Is this causing more work for the translators or causing incorrect translations?

[Morgan Fainberg (mdrnstm)]

It is emitting translated messages to logs.

OpenStack has standardized on translating only the exception messages.

[Lance Bragstad (lbragstad)]

I don't think this is a hard blocker for Rocky RC1, but since it was targetted to rocky-3 I'm bumping it to rocky-rc1.

[Vishakha Agarwal (vishakha.agarwal)]

Hi Sonu,

Are you working on it?

Thanks

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/596683

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/596683
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=67435147ec4fc9762743c9474a17999a500fda07
Submitter: Zuul
Branch: master

commit 67435147ec4fc9762743c9474a17999a500fda07
Author: Vishakha Agarwal <email address hidden>
Date: Mon Aug 27 15:39:23 2018 +0530

    Incorrect use of translation _()

    Keystone uses translated strings both in
    logging an exceptions. This is incorrect.
    All strings that are passed to logging
    should remain un-translated. This patch
    addresses above issue.

    Change-Id: Idf4f0bc1bd63eb8dc6dc61d8a49a9e2a93320474
    Closes-Bug: #1777671

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/keystone 15.0.0.0rc1 release candidate.