convert-overcloud-undercloud.yml fails on missing update_containers variable

[wes hayutin]

https://review.rdoproject.org/jenkins/job/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-master-upload/307/console

15:58:49 + ansible-playbook -vv convert-overcloud-undercloud.yml -e @/home/jenkins/workspace/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-master-upload/.quickstart/config/release/tripleo-ci/promotion-testing-hash-master.yml

15:58:58 TASK [extras-common : Set update_containers_append_tag for the play] ***********
15:58:58 task path: /home/jenkins/workspace/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-master-upload/.quickstart/usr/local/share/ansible/roles/extras-common/tasks/main.yml:24
15:58:58 Saturday 16 June 2018 15:58:58 +0000 (0:00:00.085) 0:00:05.971 *********
15:58:58 fatal: [localhost]: FAILED! => {"failed": true, "msg": "The conditional check 'update_containers and update_containers_append_tag is undefined' failed. The error was: error while evaluating conditional (update_containers and update_containers_append_tag is undefined): 'update_containers' is undefined\n\nThe error appears to have been in '/home/jenkins/workspace/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-master-upload/.quickstart/usr/local/share/ansible/roles/extras-common/tasks/main.yml': line 24, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Set update_containers_append_tag for the play\n ^ here\n"}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/575919

[wes hayutin (weshayutin)]

also failing here
https://ci.centos.org/job/tripleo-quickstart-promote-queens-rdo_trunk-minimal/77/console

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/575992

[OpenStack Infra (hudson-openstack)]

Change abandoned by wes hayutin (<email address hidden>) on branch: master
Review: https://review.openstack.org/575919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/575992
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=9e209a28c983eab20222adbdbe7eae2971f678bf
Submitter: Zuul
Branch: master

commit 9e209a28c983eab20222adbdbe7eae2971f678bf
Author: Sagi Shnaidman <email address hidden>
Date: Sun Jun 17 20:24:24 2018 +0300

    Fix undefined update_containers variable

    When checking for update_containers var we need to check if it's
    defined at all. Also all booleans should be with |bool

    Closes-Bug: #1777261
    Change-Id: Ied1ea6f6f0656b182a6b29fd1b69fc5596ac5f28

[OpenStack Infra (hudson-openstack)]

Change abandoned by wes hayutin (<email address hidden>) on branch: master
Review: https://review.openstack.org/575919

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.