Zotero fails to capture metadata
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Low
|
Unassigned | ||
3.1 |
Won't Fix
|
Undecided
|
Unassigned | ||
3.2 |
Won't Fix
|
Undecided
|
Unassigned | ||
3.3 |
Won't Fix
|
Low
|
Unassigned | ||
3.4 |
Fix Released
|
Low
|
Unassigned | ||
3.5 |
Fix Released
|
Low
|
Unassigned |
Bug Description
* Evergreen 3.1.2
Symptom: Zotero successfully captures rich data from some catalogue records, but falls back to just a regular web page snapshot for others.
Cause: For some records, biblio.
The reason the tcn_source for some records are empty strings is because the Perl record import code sets the value to an empty string if it can't find any other source (e.g. OCLC number) to avoid causing a Perl warning in the logger info call. The empty string then gets passed to the database, meaning that it satisfies the non-NULL constraint and doesn't invoke the default value of 'AUTOGEN'.
The simple fix is to not set the value of the tcn_source field in the bib record object if the corresponding variable evaluates to false (such as if it's an empty string).
Changed in evergreen: | |
milestone: | 3.1.3 → 3.1.4 |
Changed in evergreen: | |
milestone: | 3.1.4 → 3.1.5 |
Changed in evergreen: | |
milestone: | 3.1.5 → 3.1.6 |
Changed in evergreen: | |
milestone: | 3.1.6 → 3.2.1 |
Changed in evergreen: | |
milestone: | 3.2.1 → 3.2.2 |
Changed in evergreen: | |
milestone: | 3.2.2 → 3.2.3 |
Changed in evergreen: | |
milestone: | 3.2.3 → 3.3-beta1 |
Changed in evergreen: | |
importance: | Undecided → Low |
assignee: | nobody → Dan Wells (dbw2) |
Changed in evergreen: | |
milestone: | 3.3-beta1 → 3.3-rc |
Changed in evergreen: | |
milestone: | 3.3-rc → 3.3.1 |
Changed in evergreen: | |
assignee: | Dan Wells (dbw2) → Galen Charlton (gmc) |
Changed in evergreen: | |
milestone: | 3.3.1 → 3.3.2 |
Changed in evergreen: | |
milestone: | 3.3.2 → 3.3.3 |
Changed in evergreen: | |
milestone: | 3.3.3 → 3.3.4 |
Changed in evergreen: | |
milestone: | 3.3.4 → 3.3.5 |
Changed in evergreen: | |
milestone: | 3.3.5 → 3.4.2 |
Changed in evergreen: | |
milestone: | 3.4.2 → 3.4.3 |
Changed in evergreen: | |
milestone: | 3.4.3 → 3.4.4 |
Changed in evergreen: | |
milestone: | 3.4.4 → 3.5.1 |
Changed in evergreen: | |
milestone: | 3.5.1 → 3.5.2 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
A branch with one of the larger ratios of commit description to actual patch length is available in the working repository at user/dbs/ lp1776954_ avoid_empty_ string_ tcn_source (http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ dbs/lp1776954_ avoid_empty_ string_ tcn_source).