pan while moving mouse after cancelling selection box

Bug #1776648 reported by eelik
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Undecided
ronnie

Bug Description

1. Check "pan while moving object" in preferences.
2. Start drawing a selection box with left mouse button down.
3. While still drawing (button down), press Esc to cancel.
4. Release the mouse button, move mouse outside the view area.

It pans even though nothing is moved or even selected.

A remedy is to make a new selection box.

Application: kicad
Version: (5.0.0-rc2-129-g72b49accc), release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags: gal pcbnew
eelik (eelik)
description: updated
Revision history for this message
Nick Østergaard (nickoe) wrote :

Is this in pcbnew or eeschema?

Revision history for this message
eelik (eelik) wrote :

I didn't even know there was such option in eeschema :) But it happens in pcbnew, both with board and footprint editor. And while I'm at it, I tested in Linux, too:

Application: kicad
Version: (5.0.0-rc2-97-gabd8927d7), release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.55.1 OpenSSL/1.0.2g zlib/1.2.11 libidn2/2.0.2 libpsl/0.18.0 (+libidn2/2.0.2) librtmp/2.3
Platform: Linux 4.13.0-45-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.62.0
    Curl: 7.55.1
    Compiler: GCC 7.2.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=OFF
    KICAD_USE_OCC=OFF
    KICAD_SPICE=OFF

Revision history for this message
Seth Hillbrand (sethh) wrote :

Does this happen in the modern canvas, legacy or both?

Revision history for this message
eelik (eelik) wrote :

It seems to be only in modern.

tags: added: gal pcbnew
Revision history for this message
ronnie (ronnie81) wrote :

I encountered similar inconsistency regarding the auto pan feature with other tools (not yet reported as bug; just discovered last night).

The cause is that pcbnew/tools/selection_tool.cpp:557 SELECTION_TOOL::selectMultiple()
doesn't call setAutoPan(false) when breaking out of the while because of a cancel. See attached patch.

NB: There's also a selectMultiple in gerbview/tools/... with possibly the same issue. Sorry I didn't investigate.

Application: pcbnew
Version: (6.0.0-rc1-dev-249-gfb28d45-dirty), debug build
Libraries:
    wxWidgets 3.0.2
Platform: Linux 4.4.0-131-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=OFF
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=OFF
    KICAD_USE_OCE=OFF
    KICAD_USE_OCC=OFF
    KICAD_SPICE=OFF

Revision history for this message
ronnie (ronnie81) wrote :

Polished patch... Ready for merge?

Revision history for this message
ronnie (ronnie81) wrote :

I'm glad for any feedback on this patch. Thanks in advance.

Revision history for this message
Maciej Suminski (orsonmmz) wrote :

I have committed your patch in 46fddab1. Thank you Ronnie, sincere apologies for the delay.

Changed in kicad:
milestone: none → 5.0.1
assignee: nobody → ronnie (ronnie81)
status: New → Fix Committed
Revision history for this message
Seth Hillbrand (sethh) wrote :

Cherry-picked into v5.0 branch commit fbd6654f9

Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.