openstack overcloud delete fails with Error occurred during stack delete 'Client' object has no attribute 'workflow_engine'

[Raoul Scarazzini]

This issue seems like a regression of the previously solved bug [1], it can be reproduced in the same exact way:

[stack@undercloud ~]$ source stackrc
(undercloud) [stack@undercloud ~]$ openstack --debug overcloud delete overcloud --yes
Started Mistral Workflow tripleo.stack.v1.delete_stack. Execution ID: 6a309f97-78b2-4253-a2c4-c99e01311158
Waiting for messages on queue 'tripleo' with no timeout.
Deleting plan overcloud...
Error occurred while deleting plan 'Client' object has no attribute 'workflow_engine'
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/cliff/app.py", line 399, in run_subcommand
    result = cmd.run(parsed_args)
  File "/usr/lib/python2.7/site-packages/tripleoclient/command.py", line 25, in run
    super(Command, self).run(parsed_args)
  File "/usr/lib/python2.7/site-packages/osc_lib/command/command.py", line 41, in run
    return super(Command, self).run(parsed_args)
  File "/usr/lib/python2.7/site-packages/cliff/command.py", line 184, in run
    return_code = self.take_action(parsed_args) or 0
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_delete.py", line 96, in take_action
    self._plan_delete(workflow_client, parsed_args.stack)
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_delete.py", line 77, in _plan_delete
    "Error occurred while deleting plan {}".format(err))
CommandError: Error occurred while deleting plan 'Client' object has no attribute 'workflow_engine'
clean_up DeleteOvercloud: Error occurred while deleting plan 'Client' object has no attribute 'workflow_engine'
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/osc_lib/shell.py", line 134, in run
    ret_val = super(OpenStackShell, self).run(argv)
  File "/usr/lib/python2.7/site-packages/cliff/app.py", line 278, in run
    result = self.run_subcommand(remainder)
  File "/usr/lib/python2.7/site-packages/osc_lib/shell.py", line 169, in run_subcommand
    ret_value = super(OpenStackShell, self).run_subcommand(argv)
  File "/usr/lib/python2.7/site-packages/cliff/app.py", line 399, in run_subcommand
    result = cmd.run(parsed_args)
  File "/usr/lib/python2.7/site-packages/tripleoclient/command.py", line 25, in run
    super(Command, self).run(parsed_args)
  File "/usr/lib/python2.7/site-packages/osc_lib/command/command.py", line 41, in run
    return super(Command, self).run(parsed_args)
  File "/usr/lib/python2.7/site-packages/cliff/command.py", line 184, in run
    return_code = self.take_action(parsed_args) or 0
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_delete.py", line 96, in take_action
    self._plan_delete(workflow_client, parsed_args.stack)
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_delete.py", line 77, in _plan_delete
    "Error occurred while deleting plan {}".format(err))
CommandError: Error occurred while deleting plan 'Client' object has no attribute 'workflow_engine'

END return value: 1

Used releases:

openstack-tripleo-puppet-elements-9.0.0-0.20180602004307.939b586.el7.noarch
openstack-tripleo-image-elements-9.0.0-0.20180601015717.2ac38dd.el7.noarch
openstack-tripleo-heat-templates-9.0.0-0.20180604091844.d5a2c0b.el7.noarch
python-tripleoclient-10.1.1-0.20180601114328.cd0c931.el7.noarch
openstack-tripleo-common-containers-9.0.2-0.20180602091817.fb9a384.el7.noarch
openstack-tripleo-validations-9.0.1-0.20180601011353.9cf1f89.el7.noarch
openstack-tripleo-ui-9.0.1-0.20180523202213.73df625.el7.noarch
openstack-tripleo-common-9.0.2-0.20180602091817.fb9a384.el7.noarch
puppet-tripleo-9.0.1-0.20180531181431.b850135.el7.noarch
python-tripleoclient-heat-installer-10.1.1-0.20180601114328.cd0c931.el7.noarch

[1] https://bugs.launchpad.net/tripleo/+bug/1663416

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/574623

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/574623
Reason: The gate is having serious troubles with docker.io, we need to abandon this patch so it leaves the gate and when it's stable again I will restore this patch. Please do not restore or do anything, I'll take care of it as soon as things work again.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/574623
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=ec38f48761d0ae7394d17a1ec8a517000aa4c79e
Submitter: Zuul
Branch: master

commit ec38f48761d0ae7394d17a1ec8a517000aa4c79e
Author: Michele Baldessari <email address hidden>
Date: Tue Jun 12 09:50:24 2018 +0200

    Fix overcloud delete command

    In change I6d41f74f9271c17bcae67eb3c09460051f55667f we changed the
    signature of delete_deployment_plan from:
    def delete_deployment_plan(workflow_client, **input_)

    to:
    def delete_deployment_plan(clients, **workflow_input)

    In that change we did adjust tripleoclient/v1/overcloud_plan.py
    but we forgot the overcloud delete.

    We need to make sure we pass the clients and not the workflow_engine
    itself when we invoke the function in tripleoclient.

    Tested-By: Raoul Scarazzini <email address hidden>

    Change-Id: I88642f5d60be629de90312523a3a9c5ea1e4fd63
    Closes-Bug: #1776313

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 10.3.0 release.