Pcbnew- cancel Properties dialog, graphic item deselected.

[ToniGraham]

PCBNEW Version: (V5.0.0-rc2-dev-659-g1f5b575ea), winXPP sp3

Graphic item not selected after edit.
I don't think this is really a bug but... ?

When I select a graphic item eg Line, Arc, Text... & then E to edit (or double click)
Clicking ok, cancel or <esc> the item is no longer selected.
(The item is visually deselected upon entering edit mode)
Unlike copper items like tracks, vias etc.. which stay selected.

Maybe it is supposed to behave this way but it is in-consistent with copper layers.

Additional Usage:
If I am operating on zoom of say 5.0 & have thin graphic lines(0.05mm), selection is with the mouse cursor, not grid snapping cross-hair cursor. As such multiple clicks are often needed & sometimes double click object is engaged & edit popup, but exit edit cancels selection. try again...

cheers

[KiCad Janitor (kicad-janitor)]

Fixed in revision 2c6d0ffe2721825ed6d481f8922dbb3eb67797c0
https://git.launchpad.net/kicad/patch/?id=2c6d0ffe2721825ed6d481f8922dbb3eb67797c0

[Maciej Suminski (orsonmmz)]

Seth,

I have noticed that it is no longer possible to undo modifications done via the property dialog since 7470d5ba. Could you have check it if you have a few spare minutes? Otherwise I will try to help.

[Seth Hillbrand (sethh)]

Hi Orson-

I just pushed adb89afe6 to fix this. Let me know if it is still present for you.

@Jeff, can you have a look at this commit? I noticed you had purposely checked against flags==0 to allow multiple actions but I couldn't tell what kind of stacking you had in mind, so if you could check that I didn't break this, I'd greatly appreciate it.

[Jeff Young (jeyjey)]

@Seth, I only appear in git because I merged two files together. But I’d bet money those comments are penned by a Frenchman. ;)

I think this is to allow you to edit properties of a newly-created-but-not-yet-placed text item or a previously-placed item being moved. I tested those and they still work fine, so I think your change is OK.

@JP, do you agree?

[Andrzej Wolski (awolski)]

@Seth, after commit 7470d5ba98 there is now ugly flickering on Windows.
When I finish routing or dragging a track, for a moment it shows the original view from before the operation, and then the new view.

[Seth Hillbrand (sethh)]

@Andrzej-

I can't find that commit number. Is it related to this bug report?

[Andrzej Wolski (awolski)]

@Seth, this is the commit that fixes this bug report.
https://git.launchpad.net/kicad/commit/?id=7470d5ba9823be7ca016d8cb3f0d463e9436cf34

[Seth Hillbrand (sethh)]

Thanks. Not sure why my grepping wasn't finding that. :)

Can you post your KiCad version information?

Also, are you routing using the accelerate toolset, fallback or Legacy?

[Andrzej Wolski (awolski)]

It happens in both OpenGL and Cairo.

Version info:

Application: pcbnew

Version: (6.0.0-rc1-dev-597-gee465fb23), release build

Libraries:

    wxWidgets 3.0.4

    libcurl/7.59.0 OpenSSL/1.0.2o (WinSSL) zlib/1.2.11 brotli/1.0.4 libidn2/2.0.5 nghttp2/1.31.1

Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW

Build Info:

    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)

    Boost: 1.66.0

    OpenCASCADE Community Edition: 6.8.0

    Curl: 7.59.0

    Compiler: GCC 7.3.0 with C++ ABI 1011

Build settings:

    USE_WX_GRAPHICS_CONTEXT=OFF

    USE_WX_OVERLAY=OFF

    KICAD_SCRIPTING=ON

    KICAD_SCRIPTING_MODULES=ON

    KICAD_SCRIPTING_WXPYTHON=ON

    KICAD_SCRIPTING_ACTION_MENU=OFF

    BUILD_GITHUB_PLUGIN=ON

    KICAD_USE_OCE=ON

    KICAD_USE_OCC=OFF

    KICAD_SPICE=ON

[Andrzej Wolski (awolski)]

Video showing the problem:
https://www.dropbox.com/s/eeisaptgifbbtfp/kicad%202018-09-25%2017-56-48.mov?dl=0

[Seth Hillbrand (sethh)]

@Andrzej-

I pushed a patch that may address this issue. Please let me know if you are still experiencing it