git delete-branch did not work in case the called git config fails

Bug #1775592 reported by Martin Schaaf
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
git-extras (Ubuntu)
Confirmed
Undecided
Unassigned

Bug Description

using set -e
leads to a failing script in case git config returns a 1 as an error code
upstream has already a fix for it

See commit https://github.com/tj/git-extras/commit/fd2151f9bb837ca2c76b1441b6df5151546c4322#diff-774947abd9138b1798cc57d5e550cda2

Martin Schaaf (mascha)
summary: - git delete-branch did not work with latest git that return a an error
- code of 1 if git config did not return a value
+ git delete-branch did not work in case the called git config fails
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in git-extras (Ubuntu):
status: New → Confirmed
Revision history for this message
Benjamin Bach (benjaoming) wrote :

Confirmed and quite annoying.

Yup, I've successfully built 4.6.0 after a uupdate on the current 4.5.0 released with Bionic. It fixes the problem.

There are other bug fixes in 4.6.0:

https://github.com/tj/git-extras/releases/tag/4.6.0

Since upstream Debian has already packaged 4.6.0, can we just pull that into the Bionic repo?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.