OVS missing random OpenFlow tables with OpenDaylight deployment

[Tim Rozet]

When deploying with OpenDaylight, some of the flows may be missing on a per table basis in each OVS. This is really a bug in OpenDaylight, but at the moment there is no fix and the deployment with TripleO results in a false positive that deployment succeeded, but may be unusable. Therefore as a workaround we can insert a check into puppet-tripleo that all the tables exist, and if not, resync manually by unsetting/setting the OF controller in OVS.

[Tim Rozet (trozet)]

Note: relevant bugs where the proper fix should be addressed in ODL are https://bugzilla.redhat.com/show_bug.cgi?id=1588116
https://bugzilla.redhat.com/show_bug.cgi?id=1588115

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/573226

[OpenStack Infra (hudson-openstack)]

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: stable/queens
Review: https://review.openstack.org/573226

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/572804
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=199ddad31bed4ea81413d0b8e940d35a71256f7c
Submitter: Zuul
Branch: master

commit 199ddad31bed4ea81413d0b8e940d35a71256f7c
Author: Tim Rozet <email address hidden>
Date: Wed Jun 6 11:15:28 2018 -0400

    Adds check and resyncs ODL/OVS OF pipeline

    Some flows may be missing in OVS (on a per table basis) when deploying
    with OpenDaylight. There is no OpenDaylight fix yet for this issue, so
    this patch implements a workaround. The workaround is to check if all
    the tables exist on each OVS node. If they are missing, then reset the
    OpenFlow connection to the ODL controller, which will result in ODL
    pushing the flows again and inserting the missing flows.

    Closes-Bug: 1775436

    Change-Id: I28d13a26198268cfd1f3e9e64236605f24319a04
    Signed-off-by: Tim Rozet <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/573226
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=f7de6e7766dc51a11a4c68f292b654acce2c7153
Submitter: Zuul
Branch: stable/queens

commit f7de6e7766dc51a11a4c68f292b654acce2c7153
Author: Tim Rozet <email address hidden>
Date: Wed Jun 6 11:15:28 2018 -0400

    Adds check and resyncs ODL/OVS OF pipeline

    Some flows may be missing in OVS (on a per table basis) when deploying
    with OpenDaylight. There is no OpenDaylight fix yet for this issue, so
    this patch implements a workaround. The workaround is to check if all
    the tables exist on each OVS node. If they are missing, then reset the
    OpenFlow connection to the ODL controller, which will result in ODL
    pushing the flows again and inserting the missing flows.

    Closes-Bug: 1775436

    Change-Id: I28d13a26198268cfd1f3e9e64236605f24319a04
    Signed-off-by: Tim Rozet <email address hidden>
    (cherry picked from commit 199ddad31bed4ea81413d0b8e940d35a71256f7c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 8.3.4 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 9.2.0 release.