Mahara

Need to throw correct error in Webservices user delete

Bug #1774554 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
Mahara 18.10.0
17.04
Fix Released
High
Unassigned
Mahara 17.04.10
17.10
Fix Released
High
Unassigned
Mahara 17.10.7
18.04
Fix Released
High
Unassigned
Mahara 18.04.3
18.10
Fix Released
High
Unassigned
Mahara 18.10.0

Bug Description

Currently we are throwing a MaharaException incorrectly for a couple of rules

We should be throwing a WebserviceInvalidParameterException instead

Noticed due to this bug report https://bugs.launchpad.net/mahara/+bug/1773864

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8938

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 18.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8938
Committed: https://git.mahara.org/mahara/mahara/commit/7c8f5f5b32babb80dbb6ce4f786e3e401fdf0aa0
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 7c8f5f5b32babb80dbb6ce4f786e3e401fdf0aa0
Author: Robert Lyon <email address hidden>
Date: Fri Jun 1 13:56:11 2018 +1200

Bug 1774554: Throw WebserviceInvalidParameterException error

Instead of the MaharaException when doing user delete via webservices

behatnotneeded

Change-Id: I71db2ab3a3552918992a66310cdc3244f8d7c3a1
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/9099

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9099
Committed: https://git.mahara.org/mahara/mahara/commit/f9fe1bd2473298bf6031f5bcd05965419bcdd987
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit f9fe1bd2473298bf6031f5bcd05965419bcdd987
Author: Robert Lyon <email address hidden>
Date: Fri Jun 1 13:56:11 2018 +1200

Bug 1774554: Throw WebserviceInvalidParameterException error

Instead of the MaharaException when doing user delete via webservices

behatnotneeded

Change-Id: I71db2ab3a3552918992a66310cdc3244f8d7c3a1
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 7c8f5f5b32babb80dbb6ce4f786e3e401fdf0aa0)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/9100

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/9101

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9100
Committed: https://git.mahara.org/mahara/mahara/commit/0fc61717698f118131aadd5c6695f65d94c40251
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.10_STABLE

commit 0fc61717698f118131aadd5c6695f65d94c40251
Author: Robert Lyon <email address hidden>
Date: Fri Jun 1 13:56:11 2018 +1200

Bug 1774554: Throw WebserviceInvalidParameterException error

Instead of the MaharaException when doing user delete via webservices

behatnotneeded

Change-Id: I71db2ab3a3552918992a66310cdc3244f8d7c3a1
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 7c8f5f5b32babb80dbb6ce4f786e3e401fdf0aa0)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9101
Committed: https://git.mahara.org/mahara/mahara/commit/8afe2070bcce3c1c13ac8a68b3242a14b37a6507
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.04_STABLE

commit 8afe2070bcce3c1c13ac8a68b3242a14b37a6507
Author: Robert Lyon <email address hidden>
Date: Fri Jun 1 13:56:11 2018 +1200

Bug 1774554: Throw WebserviceInvalidParameterException error

Instead of the MaharaException when doing user delete via webservices

behatnotneeded

Change-Id: I71db2ab3a3552918992a66310cdc3244f8d7c3a1
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 7c8f5f5b32babb80dbb6ce4f786e3e401fdf0aa0)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.