Issues when upgrading DVR from bm to containers

[Brent Eagles]

Upgrading DVR compute nodes from baremetal to containers (pike->queens) is not handled well by the current environment files. The environment file should provide the configuration for the compute role, not just the new ComputeDVR role.

Note: for consistency with using the datacentre network/bridge in the default templates, the user will also need to add the "External" network to the compute role. As I would expect real world deployments to *not* do that, I don't think that's reasonable to change the default Compute role do so. A release note/docs should be sufficient there.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/571210

[Brent Eagles (beagles)]

In addition to updating the environment file, I think this requires some documentation files before closing.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/571210
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f51f84e7818f7f70e4f6f298fff6d57509af4fbd
Submitter: Zuul
Branch: master

commit f51f84e7818f7f70e4f6f298fff6d57509af4fbd
Author: Brent Eagles <email address hidden>
Date: Tue May 29 10:10:58 2018 -0230

    Support containerized DVR in compute role

    This patch adds the required parameters to the Compute role so the
    agents are configured properly on upgrade.

    Related-Bug: #1774199
    Change-Id: Iab42ae0fb13e8e92cc9903432a95e04a94a5913c

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/queens
Review: https://review.openstack.org/573199

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: stable/queens
Review: https://review.openstack.org/573199
Reason: The gate is suffering of timeouts, we need to clear it. Please do not restore or recheck this patch, I'll take care of it when gate is stable again.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/573199
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=bcc2a2d5e26e6770793b3dea80ac7c6f5e9aa0da
Submitter: Zuul
Branch: stable/queens

commit bcc2a2d5e26e6770793b3dea80ac7c6f5e9aa0da
Author: Brent Eagles <email address hidden>
Date: Tue May 29 10:10:58 2018 -0230

    Support containerized DVR in compute role

    This patch adds the required parameters to the Compute role so the
    agents are configured properly on upgrade.

    Conflicts:
     environments/neutron-ovs-dvr.yaml

    Related-Bug: #1774199
    Change-Id: Iab42ae0fb13e8e92cc9903432a95e04a94a5913c
    (cherry picked from commit f51f84e7818f7f70e4f6f298fff6d57509af4fbd)