should offer restart after system firmware upgrade

[Rachel Greenham]

The Software app launched by itself this morning to offer me a system firmware (uefi bios) update of my Dell 9370. Presumably in its role as a front-end to fwupd. That's not the bug, that's brilliant, that's pretty much my last remaining reason to keep a Windows partition dealt with. :-)

The bug is that when I clicked Update to let it do its job, the procedure *appeared* to fail, not by reporting an error, but simply returning back to the same screen offering the same update. Of course, it was a system firmware update so you need to reboot to apply it, but there was no communication from the app to that effect.

Therefore, the bug is that it *looked* like it failed, when it didn't. It's a usability/user communication issue.

Expected: After applying the update it should throw up a standard "restart needed" dialogue, as you get on eg: a kernel update. (User can obviously then choose to do it now or later, as normal.) And in that case, also, for the updates tab in Software to not continue to show the update as needing doing.

(When I did finally reboot, the update ran completely successfully.)

NB: I was watching fwupdmgr monitor while Software ran the update, and indeed it looked there as if the end-state was the previous version of the system firmware was still in place, but no errors reported, so if Software is looking at that (or a more direct-from-the-daemon equivalent) its behaviour may be rational, and the bug is really in what fwupdmgr monitor is reporting. ie: maybe whatever Software is looking at to monitor progress needs to actually report that a reboot is needed, so it can pass that along to the user.

ProblemType: Bug
DistroRelease: Ubuntu 18.04
Package: ubuntu-software 3.28.1-0ubuntu4.18.04.1
ProcVersionSignature: Ubuntu 4.15.0-23.25-generic 4.15.18
Uname: Linux 4.15.0-23-generic x86_64
ApportVersion: 2.20.9-0ubuntu7
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Sat May 26 09:07:55 2018
InstallationDate: Installed on 2018-04-19 (36 days ago)
InstallationMedia: Ubuntu 18.04 LTS "Bionic Beaver" - Alpha amd64 (20180409)
InstalledPlugins:
 gnome-software-plugin-flatpak N/A
 gnome-software-plugin-limba N/A
 gnome-software-plugin-snap 3.28.1-0ubuntu4.18.04.1
PackageArchitecture: all
SourcePackage: gnome-software
UpgradeStatus: No upgrade log present (probably fresh install)

[Mario Limonciello (superm1)]

So this is actually a duplicate of a previous issue which links to this upstream issue.
https://gitlab.gnome.org/GNOME/gnome-software/issues/341

Please subscribe to the upstream issue and add comments there, thanks!