Web Client - Claims Returned Alert Not Cleared By Check In

[Jennifer Pringle]

Evergreen 3.1

The alert for Claimed Returned and Claimed Never Checked Out items persists after the initial check in of an item in one of those states.

When you check in a claimed returned item a pop up appears "Copy alerts CHECKIN Copy was marked claims returned". If you click "OK/Continue" the item is checked in, its status is updated to Reshelving, and the item no longer displays on the patron's record as expected. If you check the item in again or go to check it out to a new patron the pop up appears again "Copy alerts CHECKIN Copy was marked claims returned".

If you check the item out to a new patron (selecting "OK/Continue" on the pop-up) when the item is next checked in the alert does not appear.

The same behaviour happens with items that are Claimed Never Checked Out.

Alerts for lost items are behaving as expected. When you check in an item with the status of Lost the pop-up appears on the initial check in but not on any subsequent check in or the next check out.

[Jason Boyer (jboyer)]

I've tracked this down to the asset.copy_state function being too permissive about which circs can cause these alerts. (LONGOVERDUE was also affected by this problem.)

The fix is simple and the branch is here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1773452_copy_alert_fix - working/user/jboyer/lp1773452_copy_alert_fix

To test, check out an item, mark it claims returned, check it in; you should get an alert. Now check it in again, another alert, and so on until you tire of the popups.

Apply the patch

Check in the item again, no alert. Repeat the checkout / mark claims returned / checkin process, you should only be alerted the first time the item is checked in, subsequent checkins will raise no ruckus.

[Jennifer Pringle (jpringle-u)]

I have tested this code and consent to signing off on it with my name, Jennifer Pringle and my email address, <email address hidden>.

[Mike Rylander (mrylander)]

Picked to master and 3.1 for great justice. Thanks, Jason and Jennifer!