Some Cinder Netapp parameters are not handled correctly

[Alan Bishop]

The TripleO heat template for Cinder's Netapp backend has a couple of
parameters that are not being properly passed to the cinder::backend::netapp
puppet resource. The two parameters are:

THT parameter Hiera data
------------- ----------
CinderNetappNfsMountOptions cinder::backend::netapp::nfs_mount_options
CinderNetappHostType cinder::backend::netapp::netapp_host_type

cinder::backend::netapp is a "define" (not "class") resource, and so
puppet-tripleo is responsible for supplying all the inputs when it
instantiates the resource.

The problem is tripleo::profile::base::cinder::volume::netapp isn't supplying
these two inputs (they're missing).

The problem can be observed by deploying a Cinder Netapp backend with any
(non-blank) CinderNetappNfsMountOptions value, and observing whether the
corresponding nfs_mount_options config setting is present in the controller's
/etc/cinder/cinder.conf.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/570256

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/570256
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=b7021aa221422aaae8a52dacdd70769c32ffc586
Submitter: Zuul
Branch: master

commit b7021aa221422aaae8a52dacdd70769c32ffc586
Author: Alan Bishop <email address hidden>
Date: Wed May 23 16:49:07 2018 -0400

    Add missing nfs_mount_options for Cinder Netapp backend

    Add nfs_mount_options parameter when instantiating cinder::backend::netapp.
    The value maps to the CinderNetappNfsMountOptions THT parameter.

    Closes-Bug: #1773013
    Change-Id: I0f6fff63a5c3d795572c8f4df98d45ae486ca19d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/570912

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/570912
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=33b406dfe6875b96b0f27211dabf0336d8d5a2be
Submitter: Zuul
Branch: stable/queens

commit 33b406dfe6875b96b0f27211dabf0336d8d5a2be
Author: Alan Bishop <email address hidden>
Date: Wed May 23 16:49:07 2018 -0400

    Add missing nfs_mount_options for Cinder Netapp backend

    Add nfs_mount_options parameter when instantiating cinder::backend::netapp.
    The value maps to the CinderNetappNfsMountOptions THT parameter.

    Closes-Bug: #1773013
    Change-Id: I0f6fff63a5c3d795572c8f4df98d45ae486ca19d
    (cherry picked from commit b7021aa221422aaae8a52dacdd70769c32ffc586)
    Conflicts:
     manifests/profile/base/cinder/volume/netapp.pp

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/571446

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/571446
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=96b19ff3f6a27079e1b8f0c6e16df4f66a2af425
Submitter: Zuul
Branch: stable/pike

commit 96b19ff3f6a27079e1b8f0c6e16df4f66a2af425
Author: Alan Bishop <email address hidden>
Date: Wed May 23 16:49:07 2018 -0400

    Add missing nfs_mount_options for Cinder Netapp backend

    Add nfs_mount_options parameter when instantiating cinder::backend::netapp.
    The value maps to the CinderNetappNfsMountOptions THT parameter.

    Closes-Bug: #1773013
    Change-Id: I0f6fff63a5c3d795572c8f4df98d45ae486ca19d
    (cherry picked from commit b7021aa221422aaae8a52dacdd70769c32ffc586)
    Conflicts:
     manifests/profile/base/cinder/volume/netapp.pp
    (cherry picked from commit 33b406dfe6875b96b0f27211dabf0336d8d5a2be)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/572372

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 9.1.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/574365

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/572372
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=9d6129c62334885f9ac66e96da45146a3862f393
Submitter: Zuul
Branch: stable/ocata

commit 9d6129c62334885f9ac66e96da45146a3862f393
Author: Alan Bishop <email address hidden>
Date: Wed May 23 16:49:07 2018 -0400

    Add missing nfs_mount_options for Cinder Netapp backend

    Add nfs_mount_options parameter when instantiating cinder::backend::netapp.
    The value maps to the CinderNetappNfsMountOptions THT parameter.

    Closes-Bug: #1773013
    Change-Id: I0f6fff63a5c3d795572c8f4df98d45ae486ca19d
    (cherry picked from commit b7021aa221422aaae8a52dacdd70769c32ffc586)
    Conflicts:
     manifests/profile/base/cinder/volume/netapp.pp
    (cherry picked from commit 33b406dfe6875b96b0f27211dabf0336d8d5a2be)
    (cherry picked from commit 96b19ff3f6a27079e1b8f0c6e16df4f66a2af425)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/574365
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=72aa53f5e8da4e3632f744c3ceab77570a993946
Submitter: Zuul
Branch: stable/newton

commit 72aa53f5e8da4e3632f744c3ceab77570a993946
Author: Alan Bishop <email address hidden>
Date: Wed May 23 16:49:07 2018 -0400

    Add missing nfs_mount_options for Cinder Netapp backend

    Add nfs_mount_options parameter when instantiating cinder::backend::netapp.
    The value maps to the CinderNetappNfsMountOptions THT parameter.

    Closes-Bug: #1773013
    Change-Id: I0f6fff63a5c3d795572c8f4df98d45ae486ca19d
    (cherry picked from commit b7021aa221422aaae8a52dacdd70769c32ffc586)
    Conflicts:
     manifests/profile/base/cinder/volume/netapp.pp
    (cherry picked from commit 33b406dfe6875b96b0f27211dabf0336d8d5a2be)
    (cherry picked from commit 96b19ff3f6a27079e1b8f0c6e16df4f66a2af425)
    (cherry picked from commit 9d6129c62334885f9ac66e96da45146a3862f393)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 8.3.4 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 6.5.14 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 7.4.14 release.