[Config] enable EDAC_DEBUG on ARM64

[Manoj Iyer]

[Impact]
Testing EDAC requires EDAC_DEBUG to be enabled. ARM64 server customers currently need to rebuild Ubuntu kernels with this config option to test EDAC support.

[Fix]
Enable EDAC_DEBUG config option in the kernel.

[Test]

[Regression Potential]
None. Limited to ARM64 architecture.

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1772516

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[Manoj Iyer (manjo)]

Tested Cosmic -proposed kernel on ThunderX, ThunderX2 and QDF2400 server. Comparing before and after dmesg output on these systems ThunderX has more debug messages in dmesg than other systems.

-- ThunderX --
ubuntu@seuss:~$ uname -a
Linux seuss 4.15.0-23-generic #25-Ubuntu SMP Wed May 23 17:59:52 UTC 2018 aarch64 aarch64 aarch64 GNU/Linux
ubuntu@seuss:~$ dmesg | grep -i debug
ubuntu@seuss:~$

ubuntu@seuss:~$ uname -a
Linux seuss 4.17.0-5-generic #6-Ubuntu SMP Tue Jul 10 12:41:51 UTC 2018 aarch64 aarch64 aarch64 GNU/Linux
ubuntu@seuss:~$ dmesg | grep -i debug
[ 2.074861] EDAC DEBUG: edac_mc_sysfs_init: device mc created
[ 35.269879] EDAC DEBUG: edac_mc_alloc: allocating 2268 bytes for mci data (2 dimms, 2 csrows/channels)
[ 35.270204] EDAC DEBUG: edac_mc_add_mc_with_groups:
[ 35.270208] EDAC DEBUG: edac_create_sysfs_mci_device: creating bus mc0
[ 35.270245] EDAC DEBUG: edac_create_sysfs_mci_device: creating device mc0
[ 35.270512] EDAC DEBUG: edac_mc_alloc: allocating 2268 bytes for mci data (2 dimms, 2 csrows/channels)
[ 35.270764] EDAC DEBUG: edac_mc_add_mc_with_groups:
[ 35.270768] EDAC DEBUG: edac_create_sysfs_mci_device: creating bus mc1
[ 35.270802] EDAC DEBUG: edac_create_sysfs_mci_device: creating device mc1
[ 35.271063] EDAC DEBUG: edac_mc_alloc: allocating 2268 bytes for mci data (2 dimms, 2 csrows/channels)
[ 35.271438] EDAC DEBUG: edac_mc_add_mc_with_groups:
[ 35.271442] EDAC DEBUG: edac_create_sysfs_mci_device: creating bus mc2
[ 35.271535] EDAC DEBUG: edac_create_sysfs_mci_device: creating device mc2
[ 35.272056] EDAC DEBUG: edac_mc_alloc: allocating 2268 bytes for mci data (2 dimms, 2 csrows/channels)
[ 35.272457] EDAC DEBUG: edac_mc_add_mc_with_groups:
[ 35.272461] EDAC DEBUG: edac_create_sysfs_mci_device: creating bus mc3
[ 35.272519] EDAC DEBUG: edac_create_sysfs_mci_device: creating device mc3
[ 35.272968] EDAC DEBUG: edac_device_register_sysfs_main_kobj:
[ 35.273265] EDAC DEBUG: edac_device_add_device:
[ 35.273268] EDAC DEBUG: find_edac_device_by_dev:
[ 35.273272] EDAC DEBUG: edac_device_create_sysfs: idx=0
[ 35.273313] EDAC DEBUG: edac_device_create_instances:
[ 35.273485] EDAC DEBUG: edac_device_register_sysfs_main_kobj:
[ 35.273823] EDAC DEBUG: edac_device_add_device:
[ 35.273826] EDAC DEBUG: find_edac_device_by_dev:
[ 35.273828] EDAC DEBUG: edac_device_create_sysfs: idx=1
[ 35.273846] EDAC DEBUG: edac_device_create_instances:
[ 35.274003] EDAC DEBUG: edac_device_register_sysfs_main_kobj:
[ 35.274243] EDAC DEBUG: edac_device_add_device:
[ 35.274245] EDAC DEBUG: find_edac_device_by_dev:
[ 35.274248] EDAC DEBUG: edac_device_create_sysfs: idx=2
[ 35.274274] EDAC DEBUG: edac_device_create_instances:
[ 35.274502] EDAC DEBUG: edac_device_register_sysfs_main_kobj:
[ 35.274751] EDAC DEBUG: edac_device_add_device:
[ 35.274753] EDAC DEBUG: find_edac_device_by_dev:
[ 35.274756] EDAC DEBUG: edac_device_create_sysfs: idx=3
[ 35.274760] EDAC DEBUG: edac_device_create_instances:
[ 35.274899] EDAC DEBUG: edac_device_register_sysfs_main_kobj:
[ 35.275140] EDAC DEBUG: edac_device_add_device:
[ 35.275143] EDAC DEBUG: find_edac_device_...

[Seth Forshee (sforshee)]

Repeating here what I said in irc.

I think we should get rid of the spam, there's a lot of clutter that's generally going to be of no use. Possibly it would be enough to change the default value of edac_debug_level to 0. But aiui what's really wanted is the files in debugfs, and if so the best option would be to split out that stuff into a CONFIG_EDAC_DEBUGFS option.

I'm going to go ahead and revert this in cosmic and unstable until we have something to reduce the spam.

[Kleber Sacilotto de Souza (kleber-souza)]

Artful is EOL.

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 4.17.0-6.7

---------------
linux (4.17.0-6.7) cosmic; urgency=medium

  * linux: 4.17.0-6.7 -proposed tracker (LP: #1783396)

  * [Regression] EXT4-fs error (device sda2): ext4_validate_block_bitmap:383:
    comm stress-ng: bg 4705: bad block bitmap checksum (LP: #1781709)
    - SAUCE: Revert "UBUNTU: SAUCE: ext4: fix ext4_validate_inode_bitmap: comm
      stress-ng: Corrupt inode bitmap"
    - SAUCE: ext4: check for allocation block validity with block group locked

  * Cosmic update to 4.17.9 stable release (LP: #1783201)
    - userfaultfd: hugetlbfs: fix userfaultfd_huge_must_wait() pte access
    - mm: hugetlb: yield when prepping struct pages
    - mm: teach dump_page() to correctly output poisoned struct pages
    - PCI / ACPI / PM: Resume bridges w/o drivers on suspend-to-RAM
    - ACPICA: Drop leading newlines from error messages
    - ACPI / battery: Safe unregistering of hooks
    - drm/amdgpu: Make struct amdgpu_atif private to amdgpu_acpi.c
    - tracing: Avoid string overflow
    - tracing: Fix missing return symbol in function_graph output
    - scsi: sg: mitigate read/write abuse
    - scsi: aacraid: Fix PD performance regression over incorrect qd being set
    - scsi: target: Fix truncated PR-in ReadKeys response
    - s390: Correct register corruption in critical section cleanup
    - drbd: fix access after free
    - vfio: Use get_user_pages_longterm correctly
    - ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl
    - ARM: dts: omap3: Fix am3517 mdio and emac clock references
    - ARM: dts: dra7: Disable metastability workaround for USB2
    - cifs: Fix use after free of a mid_q_entry
    - cifs: Fix memory leak in smb2_set_ea()
    - cifs: Fix slab-out-of-bounds in send_set_info() on SMB2 ACE setting
    - cifs: Fix infinite loop when using hard mount option
    - drm: Use kvzalloc for allocating blob property memory
    - drm/udl: fix display corruption of the last line
    - drm/amdgpu: Add amdgpu_atpx_get_dhandle()
    - drm/amdgpu: Dynamically probe for ATIF handle (v2)
    - jbd2: don't mark block as modified if the handle is out of credits
    - ext4: add corruption check in ext4_xattr_set_entry()
    - ext4: always verify the magic number in xattr blocks
    - ext4: make sure bitmaps and the inode table don't overlap with bg
      descriptors
    - ext4: always check block group bounds in ext4_init_block_bitmap()
    - ext4: only look at the bg_flags field if it is valid
    - ext4: verify the depth of extent tree in ext4_find_extent()
    - ext4: include the illegal physical block in the bad map ext4_error msg
    - ext4: clear i_data in ext4_inode_info when removing inline data
    - ext4: never move the system.data xattr out of the inode body
    - ext4: avoid running out of journal credits when appending to an inline file
    - ext4: add more inode number paranoia checks
    - ext4: add more mount time checks of the superblock
    - ext4: check superblock mapped prior to committing
    - HID: i2c-hid: Fix "incomplete report" noise
    - HID: hiddev: fix potential Spectre v1
    - HID: debug: check length before copy_to_user()
    - HID: core: allow concurrent registr...

[Manoj Iyer (manjo)]

This is fix released for Cosmic and NACked for Bionic. Marking the bionic track as won't fix.

[Brad Figg (brad-figg)]

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-bionic' to 'verification-done-bionic'. If the problem still exists, change the tag 'verification-needed-bionic' to 'verification-failed-bionic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Andy Whitcroft (apw)]

This bug was erroneously marked for verification in bionic; verification is not required and verification-needed-bionic is being removed.