Remove double-negative from ERC report ErrType(2)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
KiCad |
Fix Released
|
Low
|
Jeff Young |
Bug Description
When a global label is not connected, the ERC reports:
ErrType(2): Pin not connected (and no connect symbol found on this pin)
@ (4.000 in,3.500 in): Pin 57 (Bidirectional) of component U1 is unconnected.
The problem is NOT that there isn't a connect symbol, which is what this message says. The problem is that there isn't a no-connection flag. Thus I suggest this should read:
ErrType(2): Pin not connected (and a no-connection flag was not found on this pin)
@ (4.000 in,3.500 in): Pin 57 (Bidirectional) of component U1 is unconnected.
1) This avoids torturing English syntax (and those who struggle to read English) by avoiding using a double "no", as in "(and no no connect symbol found on this pin)".
2) The documentation for Eeschema refers to this as a "No connection flag", rather than a symbol, as does the hover text for the tool bar icon which reads "Place no connection flag". Either the error should call it a "flag" or the hover text should say "symbol". I like "flag", as this doesn't appear in a symbol library and this is how it is referred to in the documentation.
3) The error message and hover text would be clearer with a hyphen: "Place no-connection flag". This avoids suggesting that you are not placing a connection flag. If we're feeling hyphen-averse, place quotes around "no connect" as done in the documentation:
ErrType(2): Pin not connected (and a "no connection" flag was not found on this pin)
@ (4.000 in,3.500 in): Pin 57 (Bidirectional) of component U1 is unconnected.
-------
Built from sources on a private branch derived from this Git commit:
8f6ae70 Deterministic algorithm for picking field values in multiunit components
Application: kicad
Version: (5.0.0-
Libraries:
wxWidgets 3.0.2
libcurl/7.47.0 GnuTLS/3.4.10 zlib/1.2.11 libidn/1.32 librtmp/2.3
Platform: Linux 4.13.0-41-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
wxWidgets: 3.0.2 (wchar_t,wx containers,
Boost: 1.58.0
OpenCASCADE Community Edition: 6.8.0
Curl: 7.47.0
Compiler: GCC 5.4.0 with C++ ABI 1009
Build settings:
USE_
USE_
KICAD_
KICAD_
KICAD_
KICAD_
BUILD_
KICAD_
KICAD_
KICAD_SPICE=ON
Changed in kicad: | |
assignee: | nobody → Jeff Young (jeyjey) |
status: | Triaged → In Progress |
Changed in kicad: | |
milestone: | 6.0.0-rc1 → 5.1.0 |
Changed in kicad: | |
status: | In Progress → Fix Committed |
Changed in kicad: | |
status: | Fix Committed → Fix Released |
I favour:
ErrType(2): Pin not connected (use a "no connection" flag to suppress this error)
@ (4.000 in,3.500 in): Pin 57 (Bidirectional) of component U1 is unconnected.
But we're past string-freeze (for the translators) for 5.0, so this will have to wait for 6.0.