Not possible to deploy with custom network unless InternalApi network is also used

[Harald Jensås]

When I try to deploy with only External network in network_data.yaml as shown in example below. The deployment fails allNodesConfig because it has InternalApiNetworkName hard coded[1]. In the parameters section of the template parameters are only created[2] for each network in network_data.yaml.

network_data.yaml
-----------------

- name: External
  vip: true
  name_lower: external
  vlan: 610
  ip_subnet: '10.0.0.0/24'
  allocation_pools: [{'start': '10.0.0.4', 'end': '10.0.0.250'}]
  gateway_ip: '10.0.0.1'
  ipv6_subnet: '2001:db8:fd00:1000::/64'
  ipv6_allocation_pools: [{'start': '2001:db8:fd00:1000::10', 'end': '2001:db8:fd00:1000:ffff:ffff:ffff:fffe'}]
  gateway_ipv6: '2001:db8:fd00:1000::1'

Deployment error
----------------

overcloud.allNodesConfig:
  resource_type: OS::TripleO::AllNodes::SoftwareConfig
  physical_resource_id:
  status: CREATE_FAILED
  status_reason: |
    resources.allNodesConfig: Property error: resources.allNodesConfigImpl.properties.config: The Parameter (InternalApiNetName) was not provided.

[1] https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/all-nodes-config.j2.yaml#L180
[2] https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/all-nodes-config.j2.yaml#L65-L70

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/569544

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/569544
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8cfaf354d2673c9d4b8bc955ab8adc81de167b1d
Submitter: Zuul
Branch: master

commit 8cfaf354d2673c9d4b8bc955ab8adc81de167b1d
Author: Harald Jensås <email address hidden>
Date: Sat May 19 00:38:32 2018 +0200

    Only add internal_api_virtual_ip if InternalApi is in network_data

    Add's a conditional to only include internal_api_virtual_ipi
    if InternalApi network is defined in custom networks.

    Closes-Bug: 1772124
    Change-Id: I332355dc63c414aa411b3c1e09dc950b54d5d175

[Bogdan Dobrelya (bogdando)]

reverted in https://review.openstack.org/#/c/572206/

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/628151

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/628151
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=868c7685f19acdfba4aaa29ae1e12522d904f95f
Submitter: Zuul
Branch: master

commit 868c7685f19acdfba4aaa29ae1e12522d904f95f
Author: Harald Jensås <email address hidden>
Date: Thu Jan 3 11:18:59 2019 +0100

    Only add internal_api_virtual_ip if InternalApi in network_data

    Add's a conditional to only include internal_api_virtual_ip if
    InternalApi network is defined in custom networks.

    According to code comment internal_api_virtual_ip is only used
    by Contrail.

    Change-Id: Ifd8f59bd03c9bab1283e580a64957f201eb8f335
    Closes-Bug: #1772124

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.3.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/661035

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/661036

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/661035
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3ed420e8a1df7715ef4f4ba9dc4d4043889a279f
Submitter: Zuul
Branch: stable/rocky

commit 3ed420e8a1df7715ef4f4ba9dc4d4043889a279f
Author: Harald Jensås <email address hidden>
Date: Thu Jan 3 11:18:59 2019 +0100

    Only add internal_api_virtual_ip if InternalApi in network_data

    Add's a conditional to only include internal_api_virtual_ip if
    InternalApi network is defined in custom networks.

    According to code comment internal_api_virtual_ip is only used
    by Contrail.

    Change-Id: Ifd8f59bd03c9bab1283e580a64957f201eb8f335
    Closes-Bug: #1772124
    (cherry picked from commit 868c7685f19acdfba4aaa29ae1e12522d904f95f)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/661036
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=4a377819d88280c6c6fa7b6baa36b42c6778fff3
Submitter: Zuul
Branch: stable/queens

commit 4a377819d88280c6c6fa7b6baa36b42c6778fff3
Author: Harald Jensås <email address hidden>
Date: Thu Jan 3 11:18:59 2019 +0100

    Only add internal_api_virtual_ip if InternalApi in network_data

    Add's a conditional to only include internal_api_virtual_ip if
    InternalApi network is defined in custom networks.

    According to code comment internal_api_virtual_ip is only used
    by Contrail.

    Conflicts:
        puppet/all-nodes-config.j2.yaml

    Change-Id: Ifd8f59bd03c9bab1283e580a64957f201eb8f335
    Closes-Bug: #1772124
    (cherry picked from commit 868c7685f19acdfba4aaa29ae1e12522d904f95f)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.4.0 release.