tripleo

deployment errors not printed by tripleoclient

Bug #1771441 reported by James Slagle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
James Slagle
tripleo rocky-2

Bug Description

tripleoclient is not printing deployment failure errors when they happen. appears due to the usage of pprint.pformat in workflows/deployment.py, which does not actually print anything.

James Slagle (james-slagle)
Changed in tripleo:
status: New → In Progress
importance: Undecided → High
assignee: nobody → James Slagle (james-slagle)
milestone: none → rocky-2
Revision history for this message
James Slagle (james-slagle) wrote :

https://review.openstack.org/568707

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/568707

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/568707
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=5edc5f38a302accb7785aa488f788256337f6367
Submitter: Zuul
Branch: master

commit 5edc5f38a302accb7785aa488f788256337f6367
Author: James Slagle <email address hidden>
Date: Tue May 15 17:47:37 2018 -0400

    Actually print the error during deployment fail

    pprint.pformat doesn't print anything on it's own, it merely returns the
    formatted object.

    This commit makes sure the errors are actually shown by:
    - log.info the whole payload (will be seen when --verbose is true)
    - print() the payload message (will always be seen)

    Closes-Bug: #1771441
    Change-Id: Idacaeaf68eda83254e9d5db60e70502e899ae09b

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 10.2.0

This issue was fixed in the openstack/python-tripleoclient 10.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.