Fencing parameter generation uses outdated approach to drivers

Bug #1770700 reported by Dmitry Tantsur
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Dmitry Tantsur

Bug Description

First, it still supports the pxe_ssh driver which was removed long ago. Second, it expects driver names to contain _, which is not true even for some classic drivers, and is never true for hardware types. Finally, it supports the deprecated pxe_ilo and pxe_drac, but not the newer ilo and idrac.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/567896

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-tripleoclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/570349

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/567896
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=812d7e6cbb899983311001d90d6608a0c90f74a5
Submitter: Zuul
Branch: master

commit 812d7e6cbb899983311001d90d6608a0c90f74a5
Author: Dmitry Tantsur <email address hidden>
Date: Fri May 11 18:48:52 2018 +0200

    Fix handling hardware types and drivers when generating fencing parameters

    First, it still supports the pxe_ssh driver which was removed long ago.
    Second, it expects driver names to contain _, which is not true even
    for some classic drivers, and is never true for hardware types.
    Finally, it supports the deprecated pxe_ilo and pxe_drac, but not
    the newer ilo and idrac.

    Also removes the leftover code handling pxe_ssh from nodes.py.

    Closes-Bug: #1770700
    Change-Id: Iecb9ed779f311a9cf17006902732fe63bfb0713a

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/570349
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=3ab85fed342b176ff694c6abc83f2718c27176ea
Submitter: Zuul
Branch: master

commit 3ab85fed342b176ff694c6abc83f2718c27176ea
Author: Dmitry Tantsur <email address hidden>
Date: Thu May 24 10:18:36 2018 +0200

    Stop supporting the removed pxe_ssh driver in `generate fencing parameters`

    This driver was removed back in Pike. Since the os_auth argument to the workflow
    was only used with it, this argument is no longer provided.

    Change-Id: Iabeff718a0e81bef00d3993cd2e142c4a667847e
    Related-Bug: #1770700
    Depends-On: https://review.openstack.org/567896

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 9.1.0

This issue was fixed in the openstack/tripleo-common 9.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.