tripleo

Prevent updating derived_parameters in plan environment

Bug #1770109 reported by Jaganathan Palanisamy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Jaganathan Palanisamy
tripleo rocky-3

Bug Description

When deploying overcloud with update-plan-only option, need to prevent updating the derived parameters section in container plan-environment file.
derived_parameters will be used only in the deployment when using overcloud deploy without update-plan-only option.

Tags: workflows
Jaganathan Palanisamy (jaganathanp)
Changed in tripleo:
assignee: nobody → Jaganathan Palanisamy (jaganathanp)
summary: - Need to prevent updating derived_parameters in plan environment
+ Prevent updating derived_parameters in plan environment
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/567144

Changed in tripleo:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/567153

Revision history for this message
Alan Bishop (alan-bishop) wrote :

Please explain why the derived parameters in the deployment plan should not be updated when the user specifies update-plan-only. The user wants the plan updated, and they just don't want the deployment to occur.

Emilien Macchi (emilienm)
Changed in tripleo:
importance: Undecided → Medium
milestone: none → rocky-2
Emilien Macchi (emilienm)
Changed in tripleo:
milestone: rocky-2 → rocky-3
Revision history for this message
Steven Hardy (shardy) wrote :

I agree with Alan, I'm not clear why we'd update everything else in the plan but not the derived parameters?

If something changes the derive parameters workflow can always run again on the eventual deploy?

Bogdan Dobrelya (bogdando)
tags: added: workflows
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/567144
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=6f6ffe1dffb8eb29f1714c45b1cf3a7dc93bcf3e
Submitter: Zuul
Branch: master

commit 6f6ffe1dffb8eb29f1714c45b1cf3a7dc93bcf3e
Author: Jaganathan Palanisamy <email address hidden>
Date: Wed May 9 03:58:20 2018 -0400

    Prevent updating derived_parameters in plan environment

    When deploying overcloud with update-plan-only option, need to
    prevent updating the derived parameters section in container
    plan-environment file.
    derived_parameters will be used only in the deployment
    when using overcloud deploy without update-plan-only option.

    Change-Id: I35a35910e5f481d7b7fd7cfea6a20ee8e2cc6816
    Closes-Bug: #1770109

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 9.2.0

This issue was fixed in the openstack/tripleo-common 9.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-tripleoclient (master)

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/567153
Reason: This patch has no activity for a while, per policy, we abandon it. Feel free to re-open if you think you're working on it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Jaganathan Palanisamy (<email address hidden>) on branch: master
Review: https://review.opendev.org/567153
Reason: Need to implement in tripleo-ansible

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.