fluentd_sources doesn't point to container logs

[Cédric Jeanneret deactivated]

Dear Stackers,

While digging a bit in our logging infra linked to OpenStack, I found a small issue: the generated hiera hash for tripleo::profile::base::logging::fluentd::fluentd_sources is wrong when we are in a containerized environment.

Indeed, all the logs listed in this hash still point to the non-containerized service, meaning neither fluentd nor any other thing we might base on this hiera key point to the correct, live logs.

After some more digging in t-h-t, each service defines a location for its log, for instance:
in puppet/services/ceilometer-agent-central.yaml we find:
  CeilometerAgentCentralLoggingSource:
    type: json
    default:
      tag: openstack.ceilometer.agent.central
      path: /var/log/ceilometer/central.log

This path should be override when we include the environments/docker.yaml environment file, shouldn't it?

I can provide a patch for that, of course, but I'd rather get some feedback before going down on it :).

Cheers,

C.

[Bogdan Dobrelya (bogdando)]

Sounds like a plan, go for it! :)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/566228

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/568540

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/566228
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3848713182c0cdb1e0e78cee9233a278d69cf3ab
Submitter: Zuul
Branch: master

commit 3848713182c0cdb1e0e78cee9233a278d69cf3ab
Author: Cédric Jeanneret <email address hidden>
Date: Fri May 18 10:18:43 2018 +0200

    Correct log location in container environment for Fluentd

    Since we moved services in containers, their logs aren't in the old location, but
    in /var/log/containers/<service>. This patch fixes the generated Hiera hash used
    by Fluentd for its configuration

    Regarding Designate config service: some of the yaml doesn't use at all the
    `service_config_settings` parameter - they will need to be updated accordingly
    once it's supported

    Co-Authored-By: Thomas Herve <email address hidden>, Steven Hardy <email address hidden>
    Change-Id: I1bc0930de4053dc1c34b50477e82d9ccdab7ae2e
    Closes-Bug: 1769051
    Related-Bug: 1674715

[OpenStack Infra (hudson-openstack)]

Change abandoned by Steven Hardy (<email address hidden>) on branch: master
Review: https://review.openstack.org/568540

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b3 development milestone.