OpenStack Compute (nova)

Wrong arguments for 'detach_volume' of virt driver

Bug #1768965 reported by Takashi Natsume on 2018-05-03

This bug report is a duplicate of: Bug #1765742: virt_driver.detach_volume rollback calls in attach_volume failures uses wrong method signature. Edit Remove

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	In Progress	Undecided	Takashi Natsume

The 'detach_volume' method is called in nova/virt/block_device.py.

virt_driver.detach_volume(connection_info, instance, self['mount_device'], encryption=encryption)

But the signature is as follows:

detach_volume(self, context, connection_info, instance, mountpoint, encryption=None)

The context is missing.

nova master (commit 0ef3c685b9d2e0049f38fcf1a268870e69a5b9cf)

Takashi Natsume (natsume-takashi) on 2018-05-03

Changed in nova:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-05-03: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/566152

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-05-07: Change abandoned on nova (master)

Change abandoned by Takashi NATSUME (<email address hidden>) on branch: master
Review: https://review.openstack.org/566152

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Bug watches keep track of this bug in other bug trackers.