using embedded resources

[djcj]

The html help files and compiled localizations can be read from Qt's embedded resources system. But that requires adding ":/" as prefix manually. I've attached a patch that does this automatically if qpdfview is build with -DSTATIC_RES, otherwise it'll look for external resource files like it already does.
This allows me to cross-compile a single static binary for Windows.

[Adam Reichold (adamreichold)]

Hello djcj,

thank for your contribution! I would like to request that you make two changes to this patch:

* Instead of defining STATIC_RES and deriving RESPFX from that, just define RESOURCE_PREFIX to be empty by default and ":/" for embedded resources.

* The change seems incomplete? Usually I would like to do "qmake CONFIG+=static_resources" which does actually include an RCC manifest to really package these files as embedded resources and sets the necessary preprocessor definitions like RESOURCE_PREFIX.

Best regards,
Adam.

P.S.: Please consider using Launchpad's merge request feature to submit more complex changes as it greatly simplifies review and discussion and avoids having to open a bug report for each change even if it does not actually fix a bug.

[djcj (djcj)]

Here's a new patch. It will now always check for embedded resources but only compile resources if configured with "qmake CONFIG+=with_staticresources".

[Adam Reichold (adamreichold)]

Hello again,

I do like the new patch, but the files {help,translations}.qrc seem to be missing from it?

Best regards,
Adam

[djcj (djcj)]

I couldn't figure out how to attach more than one file. It's just a list of the translation and help files. I've attached both files in a zip.