using redis as collector does not support password

Bug #1768742 reported by zhangfei gao
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
osprofiler
Fix Released
Undecided
Ilya Shakhat

Bug Description

When choose redis as collector, it does not support password, reporting "NOAUTH Authentication required"
Workaround is disable redis requirepass

log:
keystone/keystone-apache-admin-error.log

2018-05-02 16:47:49.707780 mod_wsgi (pid=26): Exception occurred processing WSGI script '/var/lib/kolla/venv/bin/keystone-wsgi-admin'.
2018-05-02 16:47:49.707813 Traceback (most recent call last):
2018-05-02 16:47:49.707828 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/paste/urlmap.py", line 216, in __call__
2018-05-02 16:47:49.708040 return app(environ, start_response)
2018-05-02 16:47:49.708051 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/webob/dec.py", line 131, in __call__
2018-05-02 16:47:49.708216 resp = self.call_func(req, *args, **self.kwargs)
2018-05-02 16:47:49.708224 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/webob/dec.py", line 196, in call_func
2018-05-02 16:47:49.708267 return self.func(req, *args, **kwargs)
2018-05-02 16:47:49.708274 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/oslo_middleware/base.py", line 131, in __call__
2018-05-02 16:47:49.708397 response = req.get_response(self.application)
2018-05-02 16:47:49.708405 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/webob/request.py", line 1327, in send
2018-05-02 16:47:49.708906 application, catch_exc_info=False)
2018-05-02 16:47:49.708915 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/webob/request.py", line 1291, in call_application
2018-05-02 16:47:49.708958 app_iter = application(self.environ, start_response)
2018-05-02 16:47:49.708965 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/webob/dec.py", line 131, in __call__
2018-05-02 16:47:49.709003 resp = self.call_func(req, *args, **self.kwargs)
2018-05-02 16:47:49.709009 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/webob/dec.py", line 196, in call_func
2018-05-02 16:47:49.709045 return self.func(req, *args, **kwargs)
2018-05-02 16:47:49.709051 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/oslo_middleware/base.py", line 131, in __call__
2018-05-02 16:47:49.709089 response = req.get_response(self.application)
2018-05-02 16:47:49.709095 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/webob/request.py", line 1327, in send
2018-05-02 16:47:49.709131 application, catch_exc_info=False)
2018-05-02 16:47:49.709137 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/webob/request.py", line 1291, in call_application
2018-05-02 16:47:49.709174 app_iter = application(self.environ, start_response)
2018-05-02 16:47:49.709180 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/webob/dec.py", line 145, in __call__
2018-05-02 16:47:49.709216 return resp(environ, start_response)
2018-05-02 16:47:49.709222 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/webob/dec.py", line 131, in __call__
2018-05-02 16:47:49.709261 resp = self.call_func(req, *args, **self.kwargs)
2018-05-02 16:47:49.709267 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/webob/dec.py", line 196, in call_func
2018-05-02 16:47:49.709311 return self.func(req, *args, **kwargs)
2018-05-02 16:47:49.709316 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/oslo_middleware/base.py", line 131, in __call__
2018-05-02 16:47:49.709352 response = req.get_response(self.application)
2018-05-02 16:47:49.709358 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/webob/request.py", line 1327, in send
2018-05-02 16:47:49.709393 application, catch_exc_info=False)
2018-05-02 16:47:49.709399 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/webob/request.py", line 1291, in call_application
2018-05-02 16:47:49.709436 app_iter = application(self.environ, start_response)
2018-05-02 16:47:49.709442 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/webob/dec.py", line 131, in __call__
2018-05-02 16:47:49.709477 resp = self.call_func(req, *args, **self.kwargs)
2018-05-02 16:47:49.709482 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/webob/dec.py", line 196, in call_func
2018-05-02 16:47:49.709517 return self.func(req, *args, **kwargs)
2018-05-02 16:47:49.709523 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/ ", line 131, in __call__
2018-05-02 16:47:49.709643 with profiler.Trace(self.name, info=info):
2018-05-02 16:47:49.709650 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/osprofiler/profiler.py", line 342, in __enter__
2018-05-02 16:47:49.709834 start(self._name, info=self._info)
2018-05-02 16:47:49.709842 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/osprofiler/profiler.py", line 81, in start
2018-05-02 16:47:49.709883 profiler.start(name, info=info)
2018-05-02 16:47:49.709889 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/osprofiler/profiler.py", line 396, in start
2018-05-02 16:47:49.709926 self._notify("%s-start" % name, info)
2018-05-02 16:47:49.709932 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/osprofiler/profiler.py", line 422, in _notify
2018-05-02 16:47:49.709968 notifier.notify(payload)
2018-05-02 16:47:49.709974 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/osprofiler/notifier.py", line 33, in notify
2018-05-02 16:47:49.710078 __notifier(info)
2018-05-02 16:47:49.710086 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/osprofiler/drivers/redis_driver.py", line 71, in notify
2018-05-02 16:47:49.710211 self.db.set(key, jsonutils.dumps(data))
2018-05-02 16:47:49.710218 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/redis/client.py", line 1171, in set
2018-05-02 16:47:49.710871 return self.execute_command('SET', *pieces)
2018-05-02 16:47:49.710880 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/redis/client.py", line 668, in execute_command
2018-05-02 16:47:49.710925 return self.parse_response(connection, command_name, **options)
2018-05-02 16:47:49.710932 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/redis/client.py", line 680, in parse_response
2018-05-02 16:47:49.710967 response = connection.read_response()
2018-05-02 16:47:49.710973 File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/redis/connection.py", line 629, in read_response
2018-05-02 16:47:49.711269 raise response
2018-05-02 16:47:49.711290 ResponseError: NOAUTH Authentication required.

summary: - using redis as collector does not support pass
+ using redis as collector does not support password
Revision history for this message
Tovin Seven (tovin07) wrote :

Hi zhangfei gao, currently, yes, OSProfiler does not support redis with password.

Ilya Shakhat (shakhat)
Changed in osprofiler:
status: New → Confirmed
assignee: nobody → Ilya Shakhat (shakhat)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to osprofiler (master)

Fix proposed to branch: master
Review: https://review.openstack.org/569078

Changed in osprofiler:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to osprofiler (master)

Reviewed: https://review.openstack.org/569078
Committed: https://git.openstack.org/cgit/openstack/osprofiler/commit/?id=56e5ce42e7ba6adb58371ef5025a59f9bf353cd3
Submitter: Zuul
Branch: master

commit 56e5ce42e7ba6adb58371ef5025a59f9bf353cd3
Author: Ilya Shakhat <email address hidden>
Date: Thu May 17 11:50:53 2018 +0200

    Allow user to specify password for Redis connection

    Support full schema for connection to Redis: make port number
    optional, allow password and database number. The schema is following:
    `redis://[:password]@host[:port][/db]`

    Change-Id: I0f8be615aa95409653211b24e114d8b0870b2afa
    Closes-Bug: #1768742

Changed in osprofiler:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/osprofiler 2.2.0

This issue was fixed in the openstack/osprofiler 2.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.