THT check-up-to-date.sh in pep8 is broken

[Alex Schultz]

the ./tools/check-up-to-date.sh script is currently failing silently in the pep8 checks for THT

2018-05-01 14:28:28.034066 | ubuntu-xenial | pep8 runtests: commands[4] | bash -c ./tools/check-up-to-date.sh
2018-05-01 14:28:28.034731 | ubuntu-xenial | setting PATH=/home/zuul/src/git.openstack.org/openstack/tripleo-heat-templates/.tox/pep8/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
2018-05-01 14:28:28.036281 | ubuntu-xenial | /home/zuul/src/git.openstack.org/openstack/tripleo-heat-templates$ /bin/bash -c ./tools/check-up-to-date.sh
2018-05-01 14:28:28.038543 | ubuntu-xenial | Verifying that generated environments are in sync
2018-05-01 14:28:28.369907 | ubuntu-xenial | Writing output to /tmp/tmp.YCmGPwHkRE/environments
2018-05-01 14:28:28.370073 | ubuntu-xenial | Reading environment definitions from sample-env-generator/networking.yaml
2018-05-01 14:28:28.370213 | ubuntu-xenial | Wrote sample environment "/tmp/tmp.YCmGPwHkRE/environments/networking/neutron-midonet.yaml"
2018-05-01 14:28:28.370344 | ubuntu-xenial | Reading environment definitions from sample-env-generator/messaging.yaml
2018-05-01 14:28:28.370506 | ubuntu-xenial | Wrote sample environment "/tmp/tmp.YCmGPwHkRE/environments/messaging/rpc-rabbitmq-notify-rabbitmq-shared.yaml"
2018-05-01 14:28:28.370668 | ubuntu-xenial | Wrote sample environment "/tmp/tmp.YCmGPwHkRE/environments/messaging/rpc-qdrouterd-notify-rabbitmq-hybrid.yaml"
2018-05-01 14:28:28.370763 | ubuntu-xenial | Reading environment definitions from sample-env-generator/ssl.yaml
2018-05-01 14:28:28.370890 | ubuntu-xenial | Wrote sample environment "/tmp/tmp.YCmGPwHkRE/environments/ssl/enable-tls.yaml"
2018-05-01 14:28:28.370955 | ubuntu-xenial | Traceback (most recent call last):
2018-05-01 14:28:28.371082 | ubuntu-xenial | File "./tripleo_heat_templates/environment_generator.py", line 239, in <module>
2018-05-01 14:28:28.371116 | ubuntu-xenial | main()
2018-05-01 14:28:28.371266 | ubuntu-xenial | File "./tripleo_heat_templates/environment_generator.py", line 235, in main
2018-05-01 14:28:28.371383 | ubuntu-xenial | generate_environments(config_path, output_path)
2018-05-01 14:28:28.371566 | ubuntu-xenial | File "./tripleo_heat_templates/environment_generator.py", line 216, in generate_environments
2018-05-01 14:28:28.371663 | ubuntu-xenial | _generate_environment(env, output_path)
2018-05-01 14:28:28.371849 | ubuntu-xenial | File "./tripleo_heat_templates/environment_generator.py", line 105, in _generate_environment
2018-05-01 14:28:28.371904 | ubuntu-xenial | env['name']))
2018-05-01 14:28:28.372113 | ubuntu-xenial | RuntimeError: Did not find specified parameter names ['RabbitClientUseSSL'] in file puppet/services/nova-base.yaml for environment ssl/enable-internal-tls
2018-05-01 14:28:28.384167 | ubuntu-xenial | pep8 finish: runtests after 33.53 seconds

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/565602

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/565602
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=03c8cbcdc254dc4839e6f53352ca1d9e9290d053
Submitter: Zuul
Branch: master

commit 03c8cbcdc254dc4839e6f53352ca1d9e9290d053
Author: Alex Schultz <email address hidden>
Date: Tue May 1 16:05:02 2018 -0600

    Fix sample env data

    I934561612d26befd88a9053262836b47bdf4efb0 renamed the rabbit ssl
    parameters that we use in the same environment generate but since the
    script did not fail, it made it past CI. This change fixes the
    RabbitClientUseSsl parameter in the environment to match the new
    RpcUseSsl flag and updates the check script to fail if this happens
    again.

    Change-Id: I47c63875c6934bca2903883787467fc1804ba5da
    Closes-Bug: #1768358

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b3 development milestone.