kicad_mod roundrect_rratio has no space prefixed

[Thomas Pointhuber]

Found in: https://github.com/pointhi/kicad-footprint-generator/pull/128/commits/5493f9e63c84ad66a4534ef2a4012cfe8af4fbe1

it seems the sexpr encoder does not output a space between "layers" and "roundrect_rratio"

############
(module test (layer F.Cu) (tedit 5AE8D74B)
  (fp_text reference REF** (at 0 0.5) (layer F.SilkS)
    (effects (font (size 1 1) (thickness 0.15)))
  )
  (fp_text value test (at 0 -0.5) (layer F.Fab)
    (effects (font (size 1 1) (thickness 0.15)))
  )
  (pad 1 thru_hole roundrect (at 0 3) (size 1 1) (drill 0.5) (layers *.Cu *.Mask)(roundrect_rratio 0.25))
)
############

[Nick Østergaard (nickoe)]

Targeted v5, since this is new in v5.

[Maciej Suminski (orsonmmz)]

While the fix is trivial, it might be (slightly) upsetting for the users or library maintainers keeping their files in a repository, as they will have files changed without any actual modification.

Are there any particular problems caused by the missing space? If not, then perhaps we can fix it the next time the file format version is bumped.

[Wayne Stambaugh (stambaughw)]

On 5/2/2018 9:02 AM, Maciej Suminski wrote:
> While the fix is trivial, it might be (slightly) upsetting for the users
> or library maintainers keeping their files in a repository, as they will
> have files changed without any actual modification.

It will only be a problem for librarians when they save footprint
library. It will impact boards with rounded rectangle pads on the next
save. I would think the impact would be minimal given that rounded
rectangle support is a fairly recent addition to KiCad.

>
> Are there any particular problems caused by the missing space? If not,
> then perhaps we can fix it the next time the file format version is
> bumped.
>

Other the general file formatting, the missing space is not an issue.
The parser ignores white space. Since it's technically it's not a file
format change, it might be better to fix it now while it effects fewer
users rather than wait until it effects a lot of users. I was going to
make the change so if there are no objections I will continue on.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 7c7a6ea979f6b517e4891594559d695b8fb48a43
https://git.launchpad.net/kicad/patch/?id=7c7a6ea979f6b517e4891594559d695b8fb48a43