promoter script is not comparing timestamps correctly when folding hashes
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tripleo |
Fix Released
|
High
|
Gabriele Cerami |
Bug Description
When the promoter looks at the timestamp to choose only to promote hashes older than the one previously promoted, it's comparing timestamps from two different promotions.
So for example, when trying to promote to current-tripleo-rdo we look at the last promotion timestamp, then try to find timestamps older than this among the current-tripleo promotions.
So, if the latest promotion to current-tripleo-rdo for hash A happened after a current-tripleo promotion for hash B (and it's happening only lately that we have so many promotions) then promotion to current-tripleo-rdo for hash B will be skipped.
We need to start also confronting the hash and be sure we are comparing timestamps at the same level (current-tripleo with current-tripleo)
summary: |
- promoter script is not confronting timestamps correctly when folding + promoter script is not comparing timestamps correctly when folding hashes |
Changed in tripleo: | |
milestone: | rocky-2 → rocky-3 |
Changed in tripleo: | |
status: | In Progress → Fix Released |
tags: | removed: promotion-blocker |
tags: | added: promotion-blocker |
I'll have to rewrite the get_latest_hashes function to do a comparison based on hashes instead of just timestamps.