tripleo-ansible-inventory returns {} when creating the ansible inventory

Bug #1768011 reported by Carlos Camacho
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Carlos Camacho

Bug Description

If tripleo-ansible-inventory returns empty, the script should fail
and display an error message for the users to
fix the plan or stack name before continuing.

Reproducible: 100%

How to reproduce:
Run:
  tripleo-ansible-inventory --stack overcloasdfud

Expected result:
  Error showing that the inventory is empty
Actual result:
  '{}' it finish with a status code of 0 instead of 1

Changed in tripleo:
importance: Undecided → High
status: New → Triaged
assignee: nobody → Carlos Camacho (ccamacho)
tags: added: queens-backport-potential
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (master)

Fix proposed to branch: master
Review: https://review.openstack.org/565201

Changed in tripleo:
status: Triaged → In Progress
Changed in tripleo:
milestone: none → rocky-2
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (master)

Reviewed: https://review.openstack.org/565201
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=773bef1c7a5e7015c4df42ce23e2f9c8c158f424
Submitter: Zuul
Branch: master

commit 773bef1c7a5e7015c4df42ce23e2f9c8c158f424
Author: Carlos Camacho <email address hidden>
Date: Mon Apr 30 14:12:04 2018 +0200

    Fail if the Overcloud inventory is empty

    If tripleo-ansible-inventory can not retrieve the
    inventory, the script should fail and
    display an error message for the users to
    fix the plan or stack name before continuing.

    Change-Id: I76fe01b7f2ec84db8a8aeaa749cb7b961667b3c9
    Closes-Bug: 1768011

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/566881

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (stable/queens)

Reviewed: https://review.openstack.org/566881
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=3756506d315e661347c76f16383a279b6eb1f9e8
Submitter: Zuul
Branch: stable/queens

commit 3756506d315e661347c76f16383a279b6eb1f9e8
Author: Carlos Camacho <email address hidden>
Date: Mon Apr 30 14:12:04 2018 +0200

    Fail if the Overcloud inventory is empty

    If tripleo-ansible-inventory can not retrieve the
    inventory, the script should fail and
    display an error message for the users to
    fix the plan or stack name before continuing.

    (cherry picked from commit 773bef1c7a5e7015c4df42ce23e2f9c8c158f424)
    Change-Id: I76fe01b7f2ec84db8a8aeaa749cb7b961667b3c9
    Closes-Bug: 1768011

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-validations (master)

Reviewed: https://review.openstack.org/569371
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=9bace992f33e4935470e80470712e98c3c994634
Submitter: Zuul
Branch: master

commit 9bace992f33e4935470e80470712e98c3c994634
Author: Jose Luis Franco Arza <email address hidden>
Date: Fri May 18 12:04:26 2018 +0200

    Add std_error output to error log in tripleo-ansible-inventory.

    The standard output was missing in one of the error logs
    inside tripleo-ansible-inventory. This made it pretty
    hard to debug when ansible-playbook failed due that
    inventory script error.
    This patch also formats a little the error message to give
    some more info about the issue.

    Related-Bug: #1768011
    Change-Id: Ib240a4626bedb4d2a2d0b51caf696b3728fb7fb0

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations 8.4.2

This issue was fixed in the openstack/tripleo-validations 8.4.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations 9.1.0

This issue was fixed in the openstack/tripleo-validations 9.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.