ASUS touchpad right button not working

[Aurélien]

On my ASUS T304UA, the right button of the trackpad generates no input event whereas the left button and the left half part of the middle button works (checked with libinput-debug-events).
I checked with the latest available kernel: 4.17.0-041700rc2-generic

Needless to say that the trackpad perfectly works under Windows.

The device is:
Bus 001 Device 005: ID 0b05:184a ASUSTek Computer, Inc.

I guess that the corresponding kernel driver is: hid_multitouch

Example of libinput-debug-events : left click then right click :
-event17 POINTER_BUTTON +1.11s BTN_LEFT (272) pressed, seat count: 1
 event17 POINTER_BUTTON +1.23s BTN_LEFT (272) released, seat count: 0

It seems that there is a bug in the trackpad driver...

[Pierre Equoy (pieq)]

Hello Aurélien,

I think you filed this bug in the wrong project. I did a quick check on the Ubuntu certification website [1] and I couldn't find any ASUS computer, so I don't think the T304UA that you have has been certified. Have you bought it with Ubuntu Linux pre-installed?

If yes, then you should contact ASUS directly.

If no, then I suggest you to perform some extra steps:

1. install sosreport, launch it and attach the resulting report to this issue:

    sudo sosreport --batch

2. since this issue happens even with the latest kernel (4.17), and since you mention the trackpad works fine under Windows (so it's not a hardware problem), then it might be a bug in the driver used by the touchpad. It might be better to try to contact the maintainers of the drivers directly.

[1] https://certification.ubuntu.com/desktop/

[Po-Hsu Lin (cypressyew)]

Adding the linux package, as this should be a kernel issue.

[Aurélien (titou829)]

Hi,

Sorry I just chose the wrong package.. As you may know ASUS does not provide support for Linux for this laptop...
You will find attached to this message the result of sosreport --batch.
Please let me know if I can do something in order to help you.
Regards

[Aurélien (titou829)]

The attachment...

[Launchpad Janitor (janitor)]

[Expired for linux (Ubuntu) because there has been no activity for 60 days.]

[Aurélien (titou829)]

I just found time in order to debug this problem. I found a "bug" in the hid-multitouch driver. I also enabled the confidence management provided by this touchpad in order to avoid pointer movements when we are using the keyboard.

I'll try to submit this patch to the kernel developers team.

[Kai-Heng Feng (kaihengfeng)]

I think this commit fixes your issue?

commit ec6adef5fbc3f140c70e7499fdad818acb3a46c6
Author: Benjamin Tissoires <email address hidden>
Date: Tue Sep 4 15:31:12 2018 +0200

    HID: multitouch: fix Elan panels with 2 input modes declaration

    When implementing commit 7f81c8db5489 ("HID: multitouch: simplify
    the settings of the various features"), I wrongly removed a test
    that made sure we never try to set the second InputMode feature
    to something else than 0.

    This broke badly some recent Elan panels that now forget to send the
    click button in some area of the touchpad.

    Link: https://bugzilla.kernel.org/show_bug.cgi?id=200899
    Fixes: 7f81c8db5489 ("HID: multitouch: simplify the settings of the various features")
    Cc: <email address hidden> # v4.18+
    Signed-off-by: Benjamin Tissoires <email address hidden>
    Signed-off-by: Jiri Kosina <email address hidden>

[Aurélien (titou829)]

damned!!!! I did all this job for nothing... I didn't see the patch but seems it's exactly I encountered and the solution I found it seems that it fixes the issue right!

However as I said I also enabled the use of confidence field which really improve the use of the keyboard of this computer. IT could be interesting for other people. I'll send an email to Benjamin in order to discuss that point with him.

Thanks a lot !