FFU: updating stack outputs fails on environments using OS::TripleO::NodeExtraConfig customizations with resources.NodeExtraConfig: Property error: resources.PreDeployDeployment.properties: Property name not assigned

[Jose Luis Franco]

This launchpad is based on https://bugzilla.redhat.com/show_bug.cgi?id=1562546.

Description of problem:

FFU: updating stack outputs fails on environments using OS::TripleO::NodeExtraConfig customizations with resources.NodeExtraConfig: Property error: resources.PreDeployDeployment.properties: Property name not assigned

Version-Release number of selected component (if applicable):
openstack-tripleo-heat-templates-8.0.2-0.20180327213843.f25e2d8.el7ost.noarch

How reproducible:
100%

Steps to Reproduce:

1. Deploy OSP10 with OS::TripleO::NodeExtraConfig customizations
2. Upgrade undercloud to OSP11/12/13
3. Update heat stack output with:

openstack overcloud deploy --templates /usr/share/openstack-tripleo-heat-templates \
--overcloud-ssh-user admin \
-e /usr/share/openstack-tripleo-heat-templates/environments/network-isolation.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/network-management.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/storage-environment.yaml \
-e ~/openstack_deployment/environments/centralci-prod-customisations.yaml \
-e ~/openstack_deployment/environments/nodes.yaml \
-e ~/openstack_deployment/environments/network-environment.yaml \
-e ~/openstack_deployment/environments/disk-layout.yaml \
-e ~/openstack_deployment/environments/scheduler_hints_env.yaml \
-e ~/openstack_deployment/environments/ips-from-pool-all.yaml \
-e ~/openstack_deployment/environments/neutron-settings.yaml \
-e /home/stack/virt/docker-images.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/fast-forward-upgrade.yaml \
-e /home/stack/ffu_repos.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/config-download-environment.yaml \
-e /home/stack/ceph-ansible-env.yaml \

Actual results:
stack update fails with:

(undercloud) [stack@undercloud-0 ~]$ openstack stack failures list overcloud --long
overcloud.Controller.1.NodeExtraConfig:
  resource_type: OS::TripleO::NodeExtraConfig
  physical_resource_id: 5b610778-28e7-442e-ac29-9b53bd3223ce
  status: UPDATE_FAILED
  status_reason: |
    resources.NodeExtraConfig: Property error: resources.PreDeployDeployment.properties: Property name not assigned
overcloud.Controller.0.NodeExtraConfig:
  resource_type: OS::TripleO::NodeExtraConfig
  physical_resource_id: d5ab50c3-a6c9-4439-bb46-9963aeba7ea7
  status: UPDATE_FAILED
  status_reason: |
    resources.NodeExtraConfig: Property error: resources.PreDeployDeployment.properties: Property name not assigned
overcloud.Controller.2.NodeExtraConfig:
  resource_type: OS::TripleO::NodeExtraConfig
  physical_resource_id: 212a7d09-742f-4ad7-a267-c5e018d446d0
  status: UPDATE_FAILED
  status_reason: |
    resources.NodeExtraConfig: Property error: resources.PreDeployDeployment.properties: Property name not assigned
overcloud.Compute.1.NodeExtraConfig:
  resource_type: OS::TripleO::NodeExtraConfig
  physical_resource_id: d770153f-9d78-4993-b812-74e2449c924f
  status: UPDATE_FAILED
  status_reason: |
    resources.NodeExtraConfig: Property error: resources.PreDeployDeployment.properties: Property name not assigned
overcloud.Compute.0.NodeExtraConfig:
  resource_type: OS::TripleO::NodeExtraConfig
  physical_resource_id: 3bfafc3a-7de3-43c6-8f8f-8a3ebc9ec7f7
  status: UPDATE_FAILED
  status_reason: |
    resources.NodeExtraConfig: Property error: resources.PreDeployDeployment.properties: Property name not assigned
overcloud.CephStorage.1.NodeExtraConfig:
  resource_type: OS::TripleO::NodeExtraConfig
  physical_resource_id: 7d50364e-efd4-4cfa-a551-a4d35f63db55
  status: UPDATE_FAILED
  status_reason: |
    resources.NodeExtraConfig: Property error: resources.PreDeployDeployment.properties: Property name not assigned
overcloud.CephStorage.0.NodeExtraConfig:
  resource_type: OS::TripleO::NodeExtraConfig
  physical_resource_id: 5e8e6633-66ff-4624-bc51-c8d8e14c0d7f
  status: UPDATE_FAILED
  status_reason: |
    resources.NodeExtraConfig: Property error: resources.PreDeployDeployment.properties: Property name not assigned
overcloud.CephStorage.2.NodeExtraConfig:
  resource_type: OS::TripleO::NodeExtraConfig
  physical_resource_id: c8d211c0-4770-4043-9300-838fd641772b
  status: UPDATE_FAILED
  status_reason: |
    resources.NodeExtraConfig: Property error: resources.PreDeployDeployment.properties: Property name not assigned

Expected results:
stack update succeeds

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/564253

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/564253
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=57c2c3d69849e73578c016d0a6fb5bb56f80b40a
Submitter: Zuul
Branch: master

commit 57c2c3d69849e73578c016d0a6fb5bb56f80b40a
Author: Jose Luis Franco Arza <email address hidden>
Date: Wed Apr 25 17:26:06 2018 +0200

    Add defaults into name property for config-download.

    As in FFU the SoftwareDeployment and StructuredDeployment
    resources are being overwritten by the
    config-download-software/structured resources, if the
    name property is not defined when using one of these
    resources a 'Property name not assigned' error will
    be displayed.

    Change-Id: Iade84cc85f61d73d4c3d53473cdc235f912187ad
    Closes-Bug: #1766908

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/564773

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/564773
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=064c23dc8a18349a78b52560a36ce413dc36c1a3
Submitter: Zuul
Branch: stable/queens

commit 064c23dc8a18349a78b52560a36ce413dc36c1a3
Author: Jose Luis Franco Arza <email address hidden>
Date: Wed Apr 25 17:26:06 2018 +0200

    Add defaults into name property for config-download.

    As in FFU the SoftwareDeployment and StructuredDeployment
    resources are being overwritten by the
    config-download-software/structured resources, if the
    name property is not defined when using one of these
    resources a 'Property name not assigned' error will
    be displayed.

    Change-Id: Iade84cc85f61d73d4c3d53473cdc235f912187ad
    Closes-Bug: #1766908
    (cherry picked from commit 57c2c3d69849e73578c016d0a6fb5bb56f80b40a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.3 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b3 development milestone.