tripleoclient incorrectly handles the status messages in the deploy workflow

Bug #1766216 reported by Dougal Matthews
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
James Slagle

Bug Description

tripleoclient is waiting for a SUCCESS message, but it doesn't take into account that a sub-workflow could send one. The workflow tripleo.swift_rings_backup.v1.create_swift_rings_backup_container_plan returns a SUCCESS message.

It should wait for the final message, as that is the terminal message from that workflow execution.

Dougal Matthews (d0ugal)
tags: added: queens-backport-potential
Changed in tripleo:
status: Confirmed → In Progress
Changed in tripleo:
assignee: Dougal Matthews (d0ugal) → James Slagle (james-slagle)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/557356
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=624037db017960e6cd6ac18024544c230c078031
Submitter: Zuul
Branch: master

commit 624037db017960e6cd6ac18024544c230c078031
Author: Steven Hardy <email address hidden>
Date: Wed Mar 28 15:22:00 2018 +0100

    Don't exit on a RUNNING message for deploy workflow

    This workflow is being updated to return a RUNNING status when the
    workflow starts, so we don't want to assert that SUCCESS is the only
    valid outcome anymore.

    Related blueprint config-download-workflows

    Co-Authored-By: Dougal Matthews <email address hidden>
    Closes-Bug: #1766216
    Change-Id: I78b4fc7673a4039ed7ef32b16bb2850411f7fcc6

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 10.1.0

This issue was fixed in the openstack/python-tripleoclient 10.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/655200

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/queens)

Reviewed: https://review.opendev.org/655200
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=98a82780078a1efa0f0e0d86eecc1453f4e04963
Submitter: Zuul
Branch: stable/queens

commit 98a82780078a1efa0f0e0d86eecc1453f4e04963
Author: Steven Hardy <email address hidden>
Date: Wed Mar 28 15:22:00 2018 +0100

    Don't exit on a RUNNING message for deploy workflow

    This workflow is being updated to return a RUNNING status when the
    workflow starts, so we don't want to assert that SUCCESS is the only
    valid outcome anymore.

    Related blueprint config-download-workflows

    Co-Authored-By: Dougal Matthews <email address hidden>
    Closes-Bug: #1766216
    Change-Id: I78b4fc7673a4039ed7ef32b16bb2850411f7fcc6
    (cherry picked from commit 624037db017960e6cd6ac18024544c230c078031)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 9.3.0

This issue was fixed in the openstack/python-tripleoclient 9.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.